Opened 7 years ago

Closed 7 years ago

#15739 closed defect (fixed)

Move _setTextDirAttr method to _BidiSupport

Reported by: sashash Owned by: bill
Priority: undecided Milestone: 1.9
Component: Dijit Version: 1.7.3
Keywords: Cc: Douglas Hays
Blocked By: Blocking:

Description

Move _setTextDirAttr method to _BidiSupport

Attachments (2)

setTextDirAttr_in_BidiSupport1.patch (3.4 KB) - added by bill 7 years ago.
Patch from Alex Shensis (IBM, CCLA)
NoneAlphanumericTextBoxes.patch (16.3 KB) - added by bill 7 years ago.
Patch from Alex Shensis (IBM, CCLA)

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by bill

Patch from Alex Shensis (IBM, CCLA)

Changed 7 years ago by bill

Patch from Alex Shensis (IBM, CCLA)

comment:2 Changed 7 years ago by bill

Milestone: tbd1.9

comment:3 Changed 7 years ago by bill

In [29557]:

initial steps to make _setTextDirAttr() method in _BidiSupport.js, based on setTextDirAttr_in_BidiSupport1.patch from Alex Shensis (IBM, CCLA), refs #15739 !strict.

comment:4 Changed 7 years ago by bill

In [29558]:

removing unneeded applyTextDir() method and upgrading test to AMD, from NoneAlphanumericTextBoxes?.patch from Alex Shensis (IBM, CCLA), refs #15739 !strict.

comment:5 Changed 7 years ago by bill

In [29559]:

Make applyTextDir() second parameter optional, getting the text from the node in most cases, refs #15739 !strict. Also make the code do nothing if textDir=="", to avoid branching in other code.

comment:6 Changed 7 years ago by bill

Cc: Douglas Hays added
Resolution: fixed
Status: newclosed

I think with [29586] we can mark this fixed.

Note: See TracTickets for help on using tickets.