Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15738 closed defect (fixed)

on.js dead code

Reported by: Herman Vierendeels Owned by: Kris Zyp
Priority: undecided Milestone: 1.9
Component: Events Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

on.js

// emiter that works with native event handling
on.emit = function(target, type, event){
...
for(var i in event){
var value = event[i];//dead code??!! var value assigned but not used ??!!
if(!(i in nativeEvent)){
nativeEvent[i] = event[i];
}
}
...

Change History (4)

comment:1 Changed 7 years ago by Kitson Kelly

Component: GeneralEvents
Owner: set to Kris Zyp
Status: newassigned

Appears to be valid in that the assigned value is not used. Still appears in trunk.

comment:2 Changed 7 years ago by bill

Description: modified (diff)

comment:3 Changed 7 years ago by Kris Zyp

Resolution: fixed
Status: assignedclosed

In [30986]:

Remove dead code, fixes #15738 !strict

comment:4 Changed 7 years ago by bill

Milestone: tbd1.9
Note: See TracTickets for help on using tickets.