Opened 7 years ago

Closed 4 years ago

#15737 closed defect (patchwelcome)

dojox.dtl.filter.string._urlquote incorrectly encodes multi-byte chars

Reported by: Jonathan Owned by: Neil Roberts
Priority: undecided Milestone: 1.13
Component: DojoX DTL Version: 1.8.0rc1
Keywords: Cc:
Blocked By: Blocking:

Description

Ticket #12932 provided a fix for chars < 16 (eg. "\t"), but doesn't address multi-byte characters, eg. "é".

The current solution implemented through Dojo 1.8 creates strings that are so wrong they can't be decoded when passed a multi-byte character.

Here's an example (results are printed in your browser's console, so open it up first!): http://jsfiddle.net/LUKKW/

Using encodeURIComponent() works fine. Is there a reason for avoiding that method?

See the _urlquote() method in http://svn.dojotoolkit.org/src/dojox/trunk/dtl/filter/strings.js

Change History (1)

comment:1 Changed 4 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: newclosed

Given the lack of attention that dojox/dtl has received, I'm closing this ticket as patchwelcome. If you would like to work on a fix, please create a pull request and reopen the ticket.

Note: See TracTickets for help on using tickets.