Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15734 closed defect (fixed)

Support for textDir property in containers

Reported by: sashash Owned by: bill
Priority: undecided Milestone: 1.9
Component: Dijit Version: 1.7.3
Keywords: Cc: Douglas Hays
Blocked By: #15531 Blocking:

Description (last modified by bill)

Support for textDir property in StackController, AccordionContainer, TabContainer, TitlePane

Attachments (4)

Containers.patch (22.0 KB) - added by bill 7 years ago.
Patch from Alex Shensis (IBM, CCLA)
Container2.patch (22.0 KB) - added by bill 7 years ago.
updated patch for optional text param to applyTextDir() in [29559]
Containers2.patch (21.4 KB) - added by bill 7 years ago.
newer patch from Alex
Containers3.patch (22.9 KB) - added by bill 7 years ago.
TitlePane? isn't classified as a layout container, moving test to misc/. Not checking in yet though because these tests are getting failures against latest code.

Download all attachments as: .zip

Change History (17)

comment:1 Changed 7 years ago by bill

Description: modified (diff)

Changed 7 years ago by bill

Attachment: Containers.patch added

Patch from Alex Shensis (IBM, CCLA)

comment:2 Changed 7 years ago by bill

Milestone: tbd1.9

comment:3 Changed 7 years ago by bill

Description: modified (diff)

comment:4 Changed 7 years ago by bill

In [29556]:

Textdir support for Dialog, plus enhancement from #15734 to enforceTextDirWithUcc() to allow first argument to be null, fixes #15764, refs #15734, !strict. Patch from Alex Shensis (IBM, CCLA).

Changed 7 years ago by bill

Attachment: Container2.patch added

updated patch for optional text param to applyTextDir() in [29559]

comment:5 Changed 7 years ago by bill

Blocked By: 15531 added

Needs #15531 for StackContainer buttons.

Last edited 7 years ago by bill (previous) (diff)

Changed 7 years ago by bill

Attachment: Containers2.patch added

newer patch from Alex

Changed 7 years ago by bill

Attachment: Containers3.patch added

TitlePane? isn't classified as a layout container, moving test to misc/. Not checking in yet though because these tests are getting failures against latest code.

comment:6 Changed 7 years ago by bill

Cc: Douglas Hays added

I haven't checked this in yet because it's still getting failures against the latest code (even with the Button checkin that Doug did).

comment:7 Changed 7 years ago by bill

 GROUP "testingMenu" has 1 test to run     _AssertFailure: assertEqual() failed: 	expected
		ltr
	but got
		

 with hint: 
		Menu item should have LTR text direction
     ERROR IN: 		 function(){	
					var menuBtn = registry.byId("tc1_tablist_menuBtn");
					menuBtn.toggleDropDown();
					var menu = registry.byId("tc1_menu");					
					runner.is('ltr', menu.getChildren()[0].focusNode.dir, "Menu item should have LTR text direction");
					runner.is('rtl', menu.getChildren()[1].focusNode.dir, "Menu item should have RTL text direction 1");
					runner.is('ltr', menu.getChildren()[2].focusNode.dir, "Menu item should have LTR text direction 2");
					runner.is('rtl', menu.getChildren()[3].focusNode.dir, "Menu item should have RTL text direction 3");
					
					menuBtn.closeDropDown();
				} FAILED test: ../../dijit/tests/_BidiSupport/layout/TabContainer.html::testingMenu::Test menu 78 ms

and

GROUP "tests._BidiSupport.misc.TitlePane.Bidi" has 1 test to run     _AssertFailure: assertEqual() failed: 	expected
		rtl
	but got
		

 with hint: 
		title node had direction correspondent to 'textDir'
     ERROR IN: 		 function(){
								registry.byId("pane_2").set('textDir', "rtl");
								runner.is("rtl", registry.byId("pane_1").titleNode.dir, "title node had direction correspondent to 'textDir'");								
								runner.is("rtl", registry.byId("pane_2").titleNode.dir, "title node had direction correspondent to 'textDir'");									
							} FAILED test: ../../dijit/tests/_BidiSupport/misc/TitlePane.html::tests._BidiSupport.misc.TitlePane.Bidi::TitlePane Bidi 0 ms

comment:8 Changed 7 years ago by Douglas Hays

MenuItem? tests should be using textDirNode and not focusNode

comment:9 Changed 7 years ago by bill

And looks like the other problem is that the update for TitlePane?.js is missing.

comment:10 Changed 7 years ago by bill

In [29596]:

Support for textDir parameter for layout widgets, patch from Alex Shensis (IBM, CCLA), refs #15734 !strict.

comment:11 Changed 7 years ago by bill

Resolution: fixed
Status: newclosed

In [29597]:

Support for textDir parameter for TitlePane widget, modification of patch from Alex Shensis (IBM, CCLA), fixes #15734 !strict.

comment:12 Changed 7 years ago by bill

In [29598]:

Need to call this._set() so watch() notifications work, refs #15531, #15734, #15764 !strict.

comment:11 Changed 7 years ago by bill

In [30270]:

fix tabbing, refs #15734

Note: See TracTickets for help on using tickets.