#15734 closed defect (fixed)
Support for textDir property in containers
Reported by: | sashash | Owned by: | bill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.9 |
Component: | Dijit | Version: | 1.7.3 |
Keywords: | Cc: | Douglas Hays | |
Blocked By: | #15531 | Blocking: |
Description (last modified by )
Support for textDir property in StackController, AccordionContainer, TabContainer, TitlePane
Attachments (4)
Change History (17)
comment:1 Changed 9 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 9 years ago by
Milestone: | tbd → 1.9 |
---|
comment:3 Changed 9 years ago by
Description: | modified (diff) |
---|
Changed 9 years ago by
Attachment: | Container2.patch added |
---|
updated patch for optional text param to applyTextDir() in [29559]
Changed 8 years ago by
Attachment: | Containers3.patch added |
---|
TitlePane? isn't classified as a layout container, moving test to misc/. Not checking in yet though because these tests are getting failures against latest code.
comment:6 Changed 8 years ago by
Cc: | Douglas Hays added |
---|
I haven't checked this in yet because it's still getting failures against the latest code (even with the Button checkin that Doug did).
comment:7 Changed 8 years ago by
GROUP "testingMenu" has 1 test to run _AssertFailure: assertEqual() failed: expected ltr but got with hint: Menu item should have LTR text direction ERROR IN: function(){ var menuBtn = registry.byId("tc1_tablist_menuBtn"); menuBtn.toggleDropDown(); var menu = registry.byId("tc1_menu"); runner.is('ltr', menu.getChildren()[0].focusNode.dir, "Menu item should have LTR text direction"); runner.is('rtl', menu.getChildren()[1].focusNode.dir, "Menu item should have RTL text direction 1"); runner.is('ltr', menu.getChildren()[2].focusNode.dir, "Menu item should have LTR text direction 2"); runner.is('rtl', menu.getChildren()[3].focusNode.dir, "Menu item should have RTL text direction 3"); menuBtn.closeDropDown(); } FAILED test: ../../dijit/tests/_BidiSupport/layout/TabContainer.html::testingMenu::Test menu 78 ms
and
GROUP "tests._BidiSupport.misc.TitlePane.Bidi" has 1 test to run _AssertFailure: assertEqual() failed: expected rtl but got with hint: title node had direction correspondent to 'textDir' ERROR IN: function(){ registry.byId("pane_2").set('textDir', "rtl"); runner.is("rtl", registry.byId("pane_1").titleNode.dir, "title node had direction correspondent to 'textDir'"); runner.is("rtl", registry.byId("pane_2").titleNode.dir, "title node had direction correspondent to 'textDir'"); } FAILED test: ../../dijit/tests/_BidiSupport/misc/TitlePane.html::tests._BidiSupport.misc.TitlePane.Bidi::TitlePane Bidi 0 ms
comment:9 Changed 8 years ago by
And looks like the other problem is that the update for TitlePane?.js is missing.
Note: See
TracTickets for help on using
tickets.
See also https://github.com/wkeese/dijit/compare/textdir.