Opened 7 years ago

Closed 6 years ago

#15715 closed enhancement (fixed)

--copyTests should work with no argument, or improve doc

Reported by: bill Owned by: Rawld Gill
Priority: low Milestone: 1.9
Component: BuildSystem Version: 1.7.3
Keywords: Cc:
Blocked By: Blocking:

Description

I found that

{{{{ ./build.sh --release --releaseDir /workspace/trunk-release --profile standard --copyTests }}}

gives an error message, while the deprecated syntax works:

./build.sh --release --releaseDir /workspace/trunk-release --profile standard copyTests=true

Change History (5)

comment:1 Changed 7 years ago by Rawld Gill

Priority: undecidedlow
Status: newassigned
Type: defectenhancement

copyTests can have three values:

  1. falsy: don't copy anything tagged as a test.
  2. truthy, but not "build": copy anything marked as a test, but don't apply any transforms
  3. "build": treat a test modules like any other module and apply all appropriate transforms

So, --copyTests without any arguments is not allowed. --copyTests true or --copyTests 1 and so on should work fine

I can certainly see how that no arg to copyTests should imply true. Bill--what's your feedback...would you like that enhancement?

comment:2 Changed 7 years ago by bill

Oh I see... well it's just that the error message was confusing:

$ ./build.sh --release --releaseDir /workspace/trunk-release --profile standard --copyTests
error(343) Illegal command line argument. switch: --copyTests; position: 7

It sounds like --copyTests is illegal.

And the help message is also misleading:

OPTIONS
...
     
     --writeProfile <filename> write the processed profile to filename
     
     --copyTests               Copy test files and the DOH package.

It tells me that options like "writeProfile" take an argument, but --copyTests doesn't.

So... yeah, would be nice to make --copyTests work with no argument, or otherwise fix the error message and help message.

comment:3 Changed 7 years ago by bill

Summary: copyTests only works w/deprecated syntax--copyTests should work with no argument, or improve doc

comment:4 Changed 6 years ago by Rawld Gill

Milestone: tbd1.9

comment:5 Changed 6 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

In [31277]:

improve error reporting; fixes #15715; !strict

Note: See TracTickets for help on using tickets.