Opened 6 years ago

Last modified 2 years ago

#15686 assigned defect

BusyButton label resets to incorrect value when it has been changed programatically

Reported by: Nick Fenwick Owned by: Kitson Kelly
Priority: undecided Milestone: 1.15
Component: DojoX Form Version: 1.7.3
Keywords: Cc:
Blocked By: Blocking:

Description

If you set a BusyButton? label with .set('label', foo) the change is lost if you .makeBusy() and .cancel() the button.

The value is stored in postCreate as this._label and never updated. cancel() resets the label to that stored this._label value.

My first attempt at a quick fix is to provide a _setLabelAttr function to update this._label:

	_setLabelAttr: function(/*String*/ value) {
		this.inherited(arguments);
		this._label = value;
	},

While this fixes the behaviour, there's probably a more elegant way to handle this, for example only store this._label in makeBusy() so that it is always reset to the right value in cancel().

Attachments (1)

BusyButton_label.html (1.9 KB) - added by Nick Fenwick 6 years ago.
Simple test page using 1.7.2 CDN with two buttons demonstrating the problem.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by Nick Fenwick

Attachment: BusyButton_label.html added

Simple test page using 1.7.2 CDN with two buttons demonstrating the problem.

comment:1 Changed 6 years ago by Kitson Kelly

Owner: changed from dante to Kitson Kelly
Status: newassigned

comment:2 Changed 3 years ago by dylan

Milestone: tbd1.12

comment:3 Changed 2 years ago by dylan

Milestone: 1.131.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.