Opened 10 years ago
Closed 10 years ago
#15684 closed enhancement (fixed)
Migrate dojox/gantt to AMD syntax
Reported by: | dylan | Owned by: | dylan |
---|---|---|---|
Priority: | blocker | Milestone: | 1.8 |
Component: | DojoX Widgets | Version: | 1.8.0b1 |
Keywords: | gantt | Cc: | |
Blocked By: | Blocking: |
Description
I may be able to get an AMD migration patch done before 1.8 feature freeze. If I can get it tested and land it before Wednesday, I will.
Change History (16)
comment:1 Changed 10 years ago by
comment:3 Changed 10 years ago by
Landed a patch, tested in FF and Chrome latest.
Completely lacks docs, but wanted to land this before 1.8 freeze.
comment:4 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Closing this out, will add docs as time permits.
comment:5 Changed 10 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Docs are orthogonal but there are build errors:
error(311) Missing dependency. module: dojox/gantt/TabMenu; dependency: dojox/gantt/contextMenuTab error(311) Missing dependency. module: dojox/gantt/full/TabMenu; dependency: dojox/gantt/contextMenuTab
Looks like you made a new file but forgot to check it in. I think we should make an exception and allow this checkin before the RC.
Also note that you should use relative paths to relative modules, ie instead of:
define([ "dojox/gantt/contextMenuTab",
it should be
define([ "./contextMenuTab",
(obviously it should also be a capital C but I guess you were maintaining the previous bad naming of the class)
comment:6 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Yes, was preserving the names. Added the missing file. I'll refrain from renaming since we're past freeze.
comment:8 Changed 10 years ago by
Priority: | low → blocker |
---|---|
Resolution: | fixed |
Status: | closed → reopened |
TabMenu.js is referencing an undefined symbol GanttTaskControl:
show: function(elem, object){ if(object.constructor == GanttTaskControl){
So you get an exception when mousing over the labels in the left part of the gantt.
Also, TabMenu strangely tries to declare GanttTaskControl:
define([ ... ], function(contextMenuTab, Dialog, Button, Form, registry, declare, arrayUtil, lang, locale, request, on, dom, domClass, domConstruct, domStyle, domAttr, domGeometry, keys, parser){ return declare("dojox.gantt.GanttTaskControl", [], { ...
(Marking this as a blocker since the gantt chart is now broken.)
comment:10 Changed 10 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
OK, it's not failing anymore on hover, but surely TabMenu.js is wrong since it's accessing an undeclared variable GanttTaskControl.
comment:13 Changed 10 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
No, GanntProjectControl also references GanttTaskControl. Also, GanttTaskItem in GanttChart. And GanntTaskControl in contextMenuTabs.
comment:16 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
I'm about 75% of the way there on this conversion... hope to wrap this up by the 1.8 feature freeze date.