Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#15682 closed enhancement (fixed)

Dojox mobile mirroring to support BiDi languages

Reported by: ahmedasaleh Owned by: Eric Durocher
Priority: undecided Milestone:
Component: DojoX Mobile Version: 1.7.2
Keywords: Cc: Patrick Ruzand
Blocked By: Blocking:

Description

Some Dojox mobile widgets don't support mirroring for Right-To-Left languages like Arabic and Hebrew. For Right-To-Left languages it is required that the orientation of the widgets supports RTL direction, i.e. we need to mirror those widgets with only LTR direction. A list of some widgets that not enabled for RTL is:

*Carousel *Switch *ToolBarButton? *TabBar? *TabBarButton? *IconItem? *Heading

Herein an example for the Carousel widget, the images moves from Right-To-Left, it is required in BiDi? languages to move it in the opposite direction from Left-To-Right

<head> <script type="text/javascript"> var json = {

items: [

{src:"images/pic1.jpg"}, {src:"images/pic2.jpg"}, {src:"images/pic3.jpg"}, {src:"images/pic4.jpg"}, {src:"images/pic5.jpg"}, {src:"images/pic6.jpg"}, {src:"images/pic7.jpg"}, {src:"images/pic8.jpg"}, {src:"images/pic9.jpg"}, {src:"images/pic10.jpg"}

]

};

</script> </head> <body style="visibility: hidden;" dir="rtl">

<span jsId="store1" dir="rtl" data-dojo-type="dojo.data.ItemFileReadStore?" data="json"></span> <div data-dojo-type="dojox.mobile.Carousel" id="Carousel1" dir="rtl" navButton="true" height="280px" store="store1" numVisible="1" title=" معرض الصور "> </div>

</body>

*Browser type: mobile browsers *OS and OS Version: Android V4.0.03 , iOS V5.1.1

Attachments (8)

mobile_mirroring.patch (135.8 KB) - added by Eric Durocher 7 years ago.
Bidi mirroring support for Dojo Mobile (library code and CSS) - Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh, Eric Durocher (IBM, CCLA)
mobile_mirroring_tests_doh.patch (179.7 KB) - added by Eric Durocher 7 years ago.
Bidi mirroring support for Dojo Mobile (DOH unit tests) - Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh, Eric Durocher (IBM, CCLA)
mobile_mirroring_tests.patch (84.3 KB) - added by Eric Durocher 7 years ago.
Bidi mirroring support for Dojo Mobile (manual tests) - Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh, Eric Durocher (IBM, CCLA)
mblDomButtonGrayArrow_rtl.png (110 bytes) - added by Eric Durocher 7 years ago.
Dojo Mobile bidi mirroring support (image -> dojox\mobile\themes\common\domButtons\compat) - Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh, Eric Durocher (IBM, CCLA)
mobile_mirroring_2.patch (25.6 KB) - added by Eric Durocher 7 years ago.
Fix some issues in first Dojo Mobile mirroring patch - Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh (IBM, CCLA)
dojox.mobile.fix-26-3-2013.patch (9.3 KB) - added by Eric Durocher 7 years ago.
Fix some more mirroring issues - Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh (IBM, CCLA)
_compat.js_20130408.patch (490 bytes) - added by Damien Mandrioli 7 years ago.
Fix some more mirroring issues on IE - Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh (IBM, CCLA)
Dojox.mobile-mirroring.patch (97.2 KB) - added by Sebastien Pereira 6 years ago.
New mirroring enhancements for widgets: Accordion, FormLayout?, GridLayout?, Icon, ProgressIndicator?, Rating, ScrollablePane?, SimpleDialog?, TreeView?, ValuePicker?, ValuePickerDatePicker?, DatePicker?. [Ramy Said, Ahmed Mustafa (IBM CCLA)]

Download all attachments as: .zip

Change History (26)

comment:1 Changed 7 years ago by cjolif

Cc: Pascale Dardailler added

comment:2 Changed 7 years ago by cjolif

Cc: "Pascale Dardailler" added; Pascale Dardailler removed

comment:3 Changed 7 years ago by cjolif

Cc: "Pascale Dardailler" removed

Changed 7 years ago by Eric Durocher

Attachment: mobile_mirroring.patch added

Bidi mirroring support for Dojo Mobile (library code and CSS) - Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh, Eric Durocher (IBM, CCLA)

Changed 7 years ago by Eric Durocher

Bidi mirroring support for Dojo Mobile (DOH unit tests) - Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh, Eric Durocher (IBM, CCLA)

Changed 7 years ago by Eric Durocher

Bidi mirroring support for Dojo Mobile (manual tests) - Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh, Eric Durocher (IBM, CCLA)

Changed 7 years ago by Eric Durocher

Dojo Mobile bidi mirroring support (image -> dojox\mobile\themes\common\domButtons\compat) - Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh, Eric Durocher (IBM, CCLA)

comment:4 Changed 7 years ago by cjolif

In some cases we could avoid adding code the non bidi classes for the general case by adding more has("dojo-bidi") tests. That is the case for example of loadRtlCssFiles. I will do a few changes like that and commit.

comment:5 Changed 7 years ago by cjolif

Milestone: tbd1.9

comment:6 Changed 7 years ago by cjolif

In some cases also I think we could get rid of the bidi specify mixin and just do it in the base classes has("dojo-bidi") protected. This is particularly true when in the base class we do something and the mixin has to *revert* that something.

comment:7 Changed 7 years ago by cjolif

in SwapView.js getInherited("nextView") should probably be used to get inherited function instead of using the "callParentFunction" trick.

comment:8 Changed 7 years ago by cjolif

In [30758]:

refs #15682. Bidi mirroring support for Dojo Mobile (library code and CSS) Thanks Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh, Eric Durocher all (IBM, CCLA) with some modifications. !strict.

comment:9 Changed 7 years ago by cjolif

Resolution: fixed
Status: newclosed

In [30759]:

fixes #15682. test cases for bidi mirroring. Thanks Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh, Eric Durocher (IBM, CCLA). !strict.

comment:10 Changed 7 years ago by Eric Durocher

Right-to-left Switch widgets do not seem to work fully:

  • no animation when you click (the widget correctly switches to the opposite step, but without animation)
  • you can't drag the knob

comment:11 Changed 7 years ago by bill

In [30786]:

fix API doc, refs #15682

Changed 7 years ago by Eric Durocher

Attachment: mobile_mirroring_2.patch added

Fix some issues in first Dojo Mobile mirroring patch - Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh (IBM, CCLA)

comment:12 Changed 7 years ago by Patrick Ruzand

In [30870]:

Fix some issues in first Dojo Mobile mirroring patch, refs #15682, thx Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh (IBM, CCLA) !strict

Changed 7 years ago by Eric Durocher

Fix some more mirroring issues - Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh (IBM, CCLA)

comment:13 Changed 7 years ago by cjolif

In [31110]:

refs #15682. Fix some more mirroring issues - Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh (IBM, CCLA)

Changed 7 years ago by Damien Mandrioli

Attachment: _compat.js_20130408.patch added

Fix some more mirroring issues on IE - Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh (IBM, CCLA)

comment:14 Changed 7 years ago by Damien Mandrioli

In [31214]:

refs #15682. Fix some more mirroring issues on IE - Ramy Said, Ahmed Mustafa, Alia Naguib, Ahmed A Saleh (IBM, CCLA) !strict

Changed 6 years ago by Sebastien Pereira

New mirroring enhancements for widgets: Accordion, FormLayout?, GridLayout?, Icon, ProgressIndicator?, Rating, ScrollablePane?, SimpleDialog?, TreeView?, ValuePicker?, ValuePickerDatePicker?, DatePicker?. [Ramy Said, Ahmed Mustafa (IBM CCLA)]

comment:15 Changed 6 years ago by Sebastien Pereira

Milestone: 1.9
Resolution: fixed
Status: closedreopened

comment:16 Changed 6 years ago by Sebastien Pereira

Cc: Patrick Ruzand added

comment:17 Changed 6 years ago by Patrick Ruzand <pruzand@…>

Resolution: fixed
Status: reopenedclosed

In d1fc66522d17af4f508cf2fd0aafd14ee780fe57/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:18 Changed 6 years ago by Adrian Vasiliu

For a side-effect of the latest commit, see #18000.

Note: See TracTickets for help on using tickets.