Opened 13 years ago

Closed 8 years ago

#1568 closed enhancement (invalid)

dojo.uri.Uri does not clean up path in first argument

Reported by: eingb@… Owned by: eingb@…
Priority: low Milestone: future
Component: General Version: 0.3
Keywords: Cc: eingb@…
Blocked By: Blocking:

Description (last modified by James Burke)

If dojo.uri.Uri is only passed one argument, no cleanup of the path is done:

var uri = new dojo.uri.Uri("/foo/../bar"); dojo.debug(uri.toString()) prints /foo/../bar instead of /bar

Possible solutions

  1. Document that dojo.uri.Uri should always be called with at least a period as the second argument in order to enforce a path cleanup ;)
  1. Put the code form lines 58 - 70 into a separate helper function (say cleanPath) and call that in line 91 like so

this.path = cleanPath(r[5]);

Change History (7)

comment:1 Changed 13 years ago by dylan

Milestone: 0.6

comment:2 Changed 12 years ago by Adam Peller

Owner: changed from anonymous to James Burke

is this a bug?

comment:3 Changed 12 years ago by James Burke

Milestone: 1.01.1

comment:4 Changed 12 years ago by James Burke

Milestone: 1.11.2

comment:5 Changed 11 years ago by James Burke

Description: modified (diff)
Milestone: 1.2future

comment:6 Changed 8 years ago by ben hockey

Owner: changed from James Burke to eingb@…
Status: newpending

is this ticket still relevant? it will automatically close in 14 days if there is no response.

Last edited 8 years ago by ben hockey (previous) (diff)

comment:7 Changed 8 years ago by trac-o-bot

Resolution: invalid
Status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

Note: See TracTickets for help on using tickets.