Opened 7 years ago

Closed 6 years ago

#15669 closed defect (fixed)

[cla] [patch] dojox.widget.Rotator fails to query childnodes when dojo/selector/lite engine is used (it assumes acme)

Reported by: Claus Conrad Owned by: dylan
Priority: low Milestone: 1.9
Component: DojoX Widgets Version: 1.7.3
Keywords: Cc:
Blocked By: Blocking:

Description

Rotator.js queries for "[id='[GIVEN_ID]'] >", which fails with the lite selectorEngine (not with acme). By adding an asterisk to the query, so it becomes "[id='[GIVEN_ID]'] > *", the query works with both engines.

I have attached a patch. Please consider very carefully whether to apply it - I am new to both Dojo as well as to committing to open source projects in general. Unfortunately I don't yet have the knowledge required to prepare a test case for this patch either, all I can say is that it works for me. I'd love to see Dojo succeed, so I can continue to use it in my projects for a long time - if I did something wrong by submitting this patch, please explain what is expected and I promise to try hard to become a better contributor in the future! :)

Best regards, Claus

Attachments (1)

dojox-widget-rotator-lite-selectorengine.patch (525 bytes) - added by Claus Conrad 7 years ago.

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by Claus Conrad

comment:1 Changed 6 years ago by dylan

Milestone: tbd1.9
Owner: changed from dante to dylan
Priority: undecidedlow
Status: newassigned

Thanks for the patch, will make the fix now.

comment:2 Changed 6 years ago by dylan

Resolution: fixed
Status: assignedclosed

In [30825]:

fixes #15669, change query selector so that it works with both lite and acme query engines, not just acme. !strict

Note: See TracTickets for help on using tickets.