Opened 8 years ago

Closed 8 years ago

#15654 closed defect (fixed)

Select: control of Base text direction

Reported by: brodsky Owned by: Douglas Hays
Priority: undecided Milestone: 1.9
Component: Dijit - Form Version: 1.7.3
Keywords: Cc:
Blocked By: Blocking:

Description

Support for textDir property in Select, same as for form widget. The core support for base text direction (via textDir) was introduced via following ticket: ​http://bugs.dojotoolkit.org/ticket/12367

Attachments (2)

btd_select04.patch​ (19.5 KB) - added by bill 8 years ago.
btd_select05.patch​ (19.5 KB) - added by bill 8 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by bill

Component: Dijit → Dijit - Form
Owner: changed from bill to Douglas Hays

Changed 8 years ago by bill

Attachment: btd_select04.patch​ added

comment:2 Changed 8 years ago by bill

Milestone: tbd → 1.9

comment:3 Changed 8 years ago by bill

The patch can be simplified by removing the second argument to applyTextDir() (see [29559])... which means that no change is needed to MenuItem.js.

Also, same as #15531, likely the _setTextDirAttr() functionality in Button.js should instead be moved into _BidiSupport::_setTextDirAttr(), by either generalizing that existing method to apply to this.containerNode||this.focusNode (if this.displayNode is not set), or by perhaps setting up a new data-dojo-attach-point called textDirNode (or something like that).

Changed 8 years ago by bill

Attachment: btd_select05.patch​ added

comment:4 Changed 8 years ago by Douglas Hays

Resolution: → fixed
Status: new → closed

In [29586]:

Fixes #15531, #15654. Proxy commit for Alex Shensis (IBM,CCLA). Create a unified _setTextDirAttr method in _BidiSupport, removing same from MenuItem?. Create a custom _setTextDirAttr method for Button, and add automated testcases.

Note: See TracTickets for help on using tickets.