Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#15634 closed defect (fixed)

MenuItem: no blue top/bottom border on hover (claro)

Reported by: Paul Christopher Owned by: bill
Priority: undecided Milestone: 1.9
Component: themes Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

See discussion and JSFiddle on the mailing list: ​http://dojo-toolkit.33424.n3.nabble.com/Claro-How-to-add-missing-blue-outline-to-selection-bar-of-a-dijit-form-Select-td3987466.html

The selection bar of a FilteringSelect has a subtle blue outline at the top and the bottom. This outline misses for _KeyNavContainers (e.g. dijit.form.Select, dijit.MenuItem).

Change History (4)

comment:1 Changed 10 years ago by bill

Summary: Claro: dijit.form.Select's selection bar misses blue outline → MenuItem: no blue top/bottom border on hover (claro)

I tested back to 1.5 and there was never a border shown on hover, but I agree that there should be, to match FilteringSelect and Tree. Not sure if it's difficult because of the table or not (I think the border needs to go on the <td>'s not the <tr>.)

comment:2 Changed 10 years ago by bill

Milestone: tbd → 1.9
Owner: changed from nonken to bill
Status: new → assigned

It's there for Select now, but not plain Menu. I'll take a look.

comment:3 Changed 10 years ago by bill

Resolution: → fixed
Status: assigned → closed

In [29917]:

Make border show up for hovered item in Menu, same as it does for Select and ComboBox's drop down menu. Fixes #15634. Still needs cleanup around (pre-existing) hardcoded colors in Menu.less that slipped in in [23981], refs #12368.

comment:15 Changed 10 years ago by bill

In [29918]:

Remove hardcoded colors. Refs #12368, #15634.

Note: See TracTickets for help on using tickets.