Changes between Version 1 and Version 2 of Ticket #15631, comment 1


Ignore:
Timestamp:
Jul 13, 2012, 4:51:03 PM (9 years ago)
Author:
Brandon Payton
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15631, comment 1

    v1 v2  
    1 ATTENTION: My patch as-is likely introduces a large bug. I was eager to make a first contribution and neglected to test in older versions of IE. The patch assumes that the assignment {{{(result = xhr.responseXML)}}} never yields {{{undefined}}}. Since IE6 doesn't support the responseXML property, I think this is a bad assumption.
     1'''ATTENTION''': My patch as-is likely introduces a nasty bug. I was eager to make a first contribution and forgot to test in older versions of IE. The patch assumes that the assignment {{{(result = xhr.responseXML)}}} never yields {{{undefined}}}. Since IE6 doesn't support the responseXML property, this is a poor assumption.
    22
    3 I'm up for posting a new patch but will wait to hear what kind of fix you think is worth pursuing.
     3I'm up for creating a new patch, but since there are multiple ways to address this issue, I'll wait for feedback.
    44
    55