Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#15628 closed defect (fixed)

dojox.mobile.SimpleDialog: show() should call resize()

Reported by: Eric Durocher Owned by: Adrian Vasiliu
Priority: undecided Milestone: 1.9.2
Component: DojoX Mobile Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description

If a SimpleDialog? contains a ScrollablePane? with roundCornerMask=true, the mask will not be correctly updated when the dialog is shown. The same problem may happen with other widgets whole layout depend on the visibility. A solution is to call this.resize() in the show() method of SimpleDialog?.

Attachments (1)

dialog.htm (1.8 KB) - added by Eric Durocher 7 years ago.
Sample file that reproduces the problem (on Chrome or iPhone), uncomment the resize() to workaround the problem.

Download all attachments as: .zip

Change History (12)

Changed 7 years ago by Eric Durocher

Attachment: dialog.htm added

Sample file that reproduces the problem (on Chrome or iPhone), uncomment the resize() to workaround the problem.

comment:1 Changed 7 years ago by Eric Durocher

Additional info from original reporter:

I ended up having to call resize twice. Calling resize after show allowed the content to be displayed and it als set the dialog box to the correct size. I had not noticed that it was incorrect. However, after the resize the smaller dialog is no longer centered on the page. This seems make things work correctly:

dialog.resize(); size the dialog correctly dialog.show(); show the dialog dialog.resize(); get the content to show

[can be reproduced with the attached sample, by modifying the #scroller CSS rule with height: 200px. Not sure there is really a problem with SimpleDialog here, since the sizes of the scroller are not consistent (CSS height = 200, attribute height = 400). To investigate whether we can handle this case better)

comment:2 Changed 6 years ago by Patrick Ruzand

Owner: changed from Eric Durocher to Patrick Ruzand
Status: newassigned

comment:3 Changed 6 years ago by Adrian Vasiliu

Also reproducible using dojox/mobile/test_SimpleDialog-spinWheel.html. (To reproduce, comment out the line registry.byId('spin1').resize(); - the spin wheel inside the dialog doesn't work anymore.)

Version 0, edited 6 years ago by Adrian Vasiliu (next)

comment:4 Changed 6 years ago by Adrian Vasiliu

Version: 1.7.31.8.0

comment:5 Changed 6 years ago by Adrian Vasiliu

(Changed version from 1.7.3 to 1.8.0 because SimpleDialog? didn't exist in 1.7, and I do reproduce the issue with the attached test in 1.8.0)

comment:6 Changed 6 years ago by Adrian Vasiliu <vasiliu@…>

Resolution: fixed
Status: assignedclosed

In fe3ad3266c30165dd1205f9d51695e295cd69762/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 6 years ago by Adrian Vasiliu <vasiliu@…>

In 3309baa81fc055c3eb2985ccc9fa52264dd6b6df/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 6 years ago by Adrian Vasiliu

Resolution: fixed
Status: closedreopened

comment:9 Changed 6 years ago by Adrian Vasiliu

Owner: changed from Patrick Ruzand to Adrian Vasiliu
Status: reopenedassigned

comment:10 Changed 6 years ago by Adrian Vasiliu

Resolution: fixed
Status: assignedclosed

comment:11 Changed 6 years ago by Adrian Vasiliu

Milestone: tbd1.9.2
Note: See TracTickets for help on using tickets.