Changes between Initial Version and Version 1 of Ticket #15628, comment 3


Ignore:
Timestamp:
Aug 1, 2013, 10:37:51 AM (6 years ago)
Author:
Adrian Vasiliu
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15628, comment 3

    initial v1  
    1 Also reproducible using dojox/mobile/test_SimpleDialog-spinWheel.html. (To reproduce, comment out the line registry.byId('spin1').resize(); - the spin wheel inside the dialog doesn't work anymore.)
     1For some reason, while I get an empty dialog using the attached test in 1.8.0, this is not the case with 1.9.0 anymore.
     2
     3However, on the other side, having SimpleDialog's show() calling resize() is also helpful when the SimpleDialog contains widgets such as SpinWheel which layout needs to be redone once they are made visible. Since #16996, SpinWheel and SpinWheelSlot have a resize() method, and getting it called automatically by SimpleDialog.show() is handy. Currently, the missing call of resize() hurts in dojox/mobile/test_SimpleDialog-spinWheel.html, which works it around by an explicit call of resize().
     4
     5All in one, the addition of a resize() call in SimpleDialog.show() appears to still be helpful in the current state of the code (1.9.x).