dojox.mobile.SimpleDialog: show() should call resize()

[Eric Durocher]

If a SimpleDialog? contains a ScrollablePane? with roundCornerMask=true, the mask will not be correctly updated when the dialog is shown. The same problem may happen with other widgets whole layout depend on the visibility. A solution is to call this.resize() in the show() method of SimpleDialog?.

[Eric Durocher]

Sample file that reproduces the problem (on Chrome or iPhone), uncomment the resize() to workaround the problem.

[Eric Durocher]

Additional info from original reporter:

I ended up having to call resize twice. Calling resize after show allowed the content to be displayed and it als set the dialog box to the correct size. I had not noticed that it was incorrect. However, after the resize the smaller dialog is no longer centered on the page. This seems make things work correctly:

dialog.resize(); size the dialog correctly dialog.show(); show the dialog dialog.resize(); get the content to show

[can be reproduced with the attached sample, by modifying the #scroller CSS rule with height: 200px. Not sure there is really a problem with SimpleDialog here, since the sizes of the scroller are not consistent (CSS height = 200, attribute height = 400). To investigate whether we can handle this case better)

[Adrian Vasiliu]

For some reason, while I get an empty dialog using the attached test in 1.8.0, this is not the case with 1.9.0 anymore.

However, on the other side, having SimpleDialog?'s show() calling resize() is also helpful when the SimpleDialog? contains widgets such as SpinWheel? which layout needs to be redone once they are made visible. Since #16996, SpinWheel? and SpinWheelSlot? have a resize() method, and getting it called automatically by SimpleDialog?.show() is handy. Currently, the missing call of resize() hurts in dojox/mobile/test_SimpleDialog-spinWheel.html, which works it around by an explicit call of resize().

All in one, the addition of a resize() call in SimpleDialog?.show() appears to still be helpful in the current state of the code (1.9.x).

[Adrian Vasiliu]

(Changed version from 1.7.3 to 1.8.0 because SimpleDialog? didn't exist in 1.7, and I do reproduce the issue with the attached test in 1.8.0)

[Adrian Vasiliu <[email protected]…>]

In fe3ad3266c30165dd1205f9d51695e295cd69762/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Adrian Vasiliu <[email protected]…>]

In 3309baa81fc055c3eb2985ccc9fa52264dd6b6df/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?