Opened 7 years ago

Closed 6 years ago

#15618 closed enhancement (fixed)

onMoveItem in _EditableListMixin

Reported by: Clement Mathieu Owned by: Eric Durocher
Priority: undecided Milestone: 1.9
Component: DojoX Mobile Version: 1.8.0b1
Keywords: Cc: cjolif
Blocked By: Blocking:

Description

The _EditableListMixin class lacks a onMoveItem callback.

This callback is found in the very similar _EditableIconMixin as well as a publication. All of this is done in the _onTouchEnd method which also exist in _EditableListMixin.

That would be very helpful to have this callback.

Attachments (3)

addOnMoveItem.patch (718 bytes) - added by Clement Mathieu 6 years ago.
test_RoundRectList-connect.html (5.0 KB) - added by Clement Mathieu 6 years ago.
The associated test file
ticket15618.patch (13.1 KB) - added by Clement Mathieu 6 years ago.
fix proposed + enhancement + doh tests

Download all attachments as: .zip

Change History (11)

comment:1 Changed 7 years ago by cjolif

Cc: cjolif added
Version: 1.7.31.8.0b1

comment:2 Changed 7 years ago by cjolif

Milestone: tbd1.9

Changed 6 years ago by Clement Mathieu

Attachment: addOnMoveItem.patch added

Changed 6 years ago by Clement Mathieu

The associated test file

comment:3 Changed 6 years ago by Clement Mathieu

I posted the patch and the test under the IBM CCLA

comment:4 Changed 6 years ago by Eric Durocher

Status: newassigned

Changed 6 years ago by Clement Mathieu

Attachment: ticket15618.patch added

fix proposed + enhancement + doh tests

comment:5 Changed 6 years ago by cjolif

In [30585]:

refs #15618. Implements onMoveItem and other events in _EditableListMixin to be consistent with _EditableIconMixin. Thanks Clement Mathieu (IBM, CCLA).

comment:6 Changed 6 years ago by cjolif

Ticket will be closed once documented.

comment:7 Changed 6 years ago by cjolif

In [30593]:

refs #15618. Forgotten test files. Thanks Clement Mathieu (IBM, CCLA).

comment:8 Changed 6 years ago by cjolif

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.