Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15598 closed defect (fixed)

dijit._editor.plugins.ViewSource adds extra class to ToggleButtons in Firefox

Reported by: Matt Lauer Owned by: bill
Priority: undecided Milestone: 1.8
Component: Editor Version: 1.7.3
Keywords: Cc:
Blocked By: Blocking:

Description

When a user clicks the ViewSource? button, other Toolbar buttons are disabled. Normal Buttons disable fine, but ToggleButtons? are given the classes "dijitToggleButtonChecked dijitChecked" and "dijitToggleButtonCheckedDisabled dijitCheckedDisabled" when they were not checked. It looks bad and may confuse users (especially in our case where the ViewSource? button is close to some ToggleButtons? that are automatically classed with those checked classes).

Also, if I manually remove these classes with Firebug, I can click the disabled button and reapply the clicked classes when the button is supposed to be disabled.

This happens in Win7 and FF 13.0.1 but not in Chrome 20, IE7-9.

You can test it on this page: http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/editor/test_ViewSource.html

I can also verify this problem exists in version 1.6.1, too.

Change History (3)

comment:1 Changed 7 years ago by bill

Component: DijitEditor

I see it. Each plugin (including ToggleButton plugins like Bold) is calling updateState(), which calls editor.queryCommandState("bold"), which for some reason is returning true.

comment:2 Changed 7 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

In [29168]:

Only check and change the button state if the button is enabled and the command is enabled. \!strict fixes #15598

comment:3 Changed 7 years ago by Jared Jurkiewicz

Milestone: tbd1.8
Note: See TracTickets for help on using tickets.