Opened 7 years ago

Closed 7 years ago

#15592 closed defect (fixed)

implicitly declared global variables and unused local variables

Reported by: Simon Speich Owned by: bill
Priority: undecided Milestone: 1.8
Component: General Version: 1.7.3
Keywords: Cc:
Blocked By: Blocking:

Description

I used jetbrains phpStorm's code inspection to analyze dojo and dijit and found the following problematic code in trunk:

--- implicitly declared global variables ---
dijit.Tree.js line 1861:			nodes = [];
dom-attr.js line 83:				value = node[propName];

--- unused local variables ---
dijit.tree._dndContainer.js line 74:		var self = this;
dijit.form._SearchMixin.js line 257:		var srcNodeRef = this.srcNodeRef;
dijit.layout.StackController.js line 95:	page = button.page;
dojo.dnd.Avatar.js line 43:			icon = has("highcontrast") ? ...
dojo.js line 881:				var ..., path, ...
dojo.js line 1076:				var pseudoMid = pseudoPluginResource.mid,
dom-geometry.js line 529:			dh = db.parentNode,
has.js line line 106:				var agent = navigator.userAgent;
dojo.io.script.js line 46:			var loadEvent = has("ie") ? "onreadystatechange" : ...
dojo.io.script.js line 47:			readyRegExp = /complete|loaded/;
OpenAjax.js line 29/30/31:			var t; var f; var g;
dojo.selector.acme.js line 1107:		var nua = navigator.userAgent;

Change History (2)

comment:1 Changed 7 years ago by bill

Milestone: tbd1.8
Owner: set to bill
Status: newassigned

Thanks, I'll fix.

comment:2 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [29096]:

Fix unintended globals and unused variables, thanks Simon, fixes #15592 !strict.

Note: See TracTickets for help on using tickets.