#15590 closed defect (fixed)
fix robot timing inconsistencies
Reported by: | bill | Owned by: | bill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.7.6 |
Component: | TestFramework | Version: | 1.7.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
This ticket covers fixes to doh.robot to make the timing behavior more consistent, to avoid spurious failures due to unexpected delays of robot events.
Attachments (2)
Change History (16)
comment:1 Changed 9 years ago by
Milestone: | tbd → 1.8 |
---|---|
Owner: | set to bill |
Status: | new → assigned |
comment:2 Changed 9 years ago by
Changed 9 years ago by
Attachment: | dohEvents2.patch added |
---|
Patch to maintain listeners on <body> rather then creating/destroying them on every robot call. Like dohEvents1.patch (which is probably better than this one), shares the problem that a stopPropagation() call on IE will mask us from seeing the event. For mouse events, really need to connect to the node that the mouse is over, using document.elementFromPoint(). For keyboard it might be good enough to connect to <body>.
Changed 9 years ago by
Attachment: | dohEvents1.patch added |
---|
Patch to setup new event handler for each robot call. Needs to be enhanced to ignore mousemove notifications if they don't match the requested coordinates (see dohEvents2.patch)
comment:9 Changed 9 years ago by
Milestone: | 1.8 → 2.0 |
---|
Deferring further work until 2.0. The remaining task, as prototyped in the patches above, is to monitor mouse and keyboard events in the tested document, to know when robot has executed the command that you asked it to execute.
However, it's unclear if that code will still be needed if/when we switch from java robot to WebDriver (see http://bugs.dojotoolkit.org/attachment/ticket/12740/12740_util.patch). Presumably with WebDriver you send it a command over XHR, and the XHR doesn't return a value until the command has completed. If that's true, there's no reason to monitor events.
comment:10 Changed 7 years ago by
Milestone: | 2.0 → 1.8 |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Actually, let's just mark this fixed. The future is webdriver, so I don't think we'll have any more timing fixes for doh/robot.
Mark is backporting a bunch of DOH changes to 1.7 at which point this milestone should be changed to 1.7.6.
comment:14 Changed 7 years ago by
Milestone: | 1.8 → 1.7.6 |
---|
In [29098]: