Opened 7 years ago
Closed 6 years ago
#15578 closed defect (fixed)
[patch][cla] Editor in IE<9 gets the internal carat wrong when collapsing a text node selection
| Reported by: | Bryan Forbes | Owned by: | Jared Jurkiewicz |
|---|---|---|---|
| Priority: | high | Milestone: | 1.8 |
| Component: | Editor | Version: | 1.8.0b1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
I'm attaching a test case and patch to fix an issue where the following code, in IE<9, incorrectly moves the cursor when it is at the beginning of a line:
editor._moveToBookmark(editor._getBookmark());
In the test, the cursor must be placed at the beginning of the line with the text "three" to see the problem running that code.
Attachments (5)
Change History (17)
comment:1 Changed 7 years ago by
| Milestone: | tbd → 1.8 |
|---|---|
| Owner: | set to liucougar |
| Priority: | undecided → high |
| Status: | new → assigned |
Changed 7 years ago by
| Attachment: | editor.html added |
|---|
Changed 7 years ago by
| Attachment: | range-fix.diff added |
|---|
Changed 7 years ago by
| Attachment: | range-fix.2.diff added |
|---|
Changed 7 years ago by
| Attachment: | test.patch added |
|---|
comment:2 Changed 7 years ago by
| Owner: | changed from liucougar to Jared Jurkiewicz |
|---|
comment:4 Changed 7 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Does this really work for you? The test is failing for me on both IE8 and FF.
Changed 7 years ago by
| Attachment: | 15578.patch added |
|---|
Updated testcase that should be more correct. Requires more testing.
comment:6 Changed 7 years ago by
| Milestone: | 1.8 → 2.0 |
|---|
1.8 has been tagged; moving all outstanding tickets to next major release milestone.
comment:7 Changed 7 years ago by
| Milestone: | 2.0 → 1.9 |
|---|
comment:8 Changed 7 years ago by
| Milestone: | 1.9 → 1.10 |
|---|
Bumping this ticket since we are past the deadline for the 1.9RC. The fix can be put into 1.9.1 too, if desired.
comment:9 Changed 6 years ago by
| Owner: | changed from Jared Jurkiewicz to bpayton |
|---|---|
| Status: | reopened → assigned |
| Summary: | Editor in IE<9 gets the internal carat wrong when collapsing a text node selection → [patch][cla] Editor in IE<9 gets the internal carat wrong when collapsing a text node selection |
comment:10 Changed 6 years ago by
To reproduce problem from a user's perspective:
- backup to before patch:
$ git checkout 7f59a92a765a58ee8090b63f1f849b0031b429ef~1
- load editor.html on IE8
- click at start of word "three" then click indent button
Expected behavior: "three" indented. Not added to list, but indented:
- one
- two
three
- four
- five
Actual behavior: "two" list item doubly indented:
- one
- two
three
- four
- five
comment:11 Changed 6 years ago by
| Milestone: | 1.10 → 1.8 |
|---|---|
| Owner: | changed from bpayton to Jared Jurkiewicz |
Note that ideally "three" would become part of the list, but that's not what currently happens, even after Jared's patch.
I will fix the test case to match the current behavior and then close this ticket. Since the actual bug (about list item "two" getting double-indented) was fixed in 1.8, marking the milestone as 1.8.
comment:12 Changed 6 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
test case, except I'm not sure what the expected behavior is, I'm seeing the same thing on FF and IE9