Opened 9 years ago
Closed 8 years ago
#15574 closed defect (fixed)
Slider: Support for textDir property in HorizontalRuleLabels/VerticalRuleLabels
Reported by: | sashash | Owned by: | Douglas Hays |
---|---|---|---|
Priority: | undecided | Milestone: | 1.9 |
Component: | Dijit - Form | Version: | 1.7.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Support for base text direction in HorizontalRuleLabels/VerticalRuleLabels?
Attachments (3)
Change History (10)
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
Milestone: | tbd → 2.0 |
---|---|
Owner: | changed from Douglas Hays to bill |
Status: | new → assigned |
Changed 8 years ago by
Attachment: | BidiRulers.2.patch added |
---|
comment:3 Changed 8 years ago by
Milestone: | 2.0 → 1.9 |
---|---|
Summary: | Support for textDir property in HorizontalRuleLabels/VerticalRuleLabels → Slider: Support for textDir property in HorizontalRuleLabels/VerticalRuleLabels |
comment:4 Changed 8 years ago by
Owner: | changed from bill to Douglas Hays |
---|
I don't know why I assigned this to myself, seems like it should be for Doug.
comment:5 Changed 8 years ago by
Also, seems strange to call destroyRendering(false) rather than destroyRendering(). Theoretically the former will leave the old DOM around. Is that what we want? (Of course, maybe the whole idea to support dyanamically changing the textDir is a mistake too, if we need code this complicated to do it.)
Changed 8 years ago by
Attachment: | 15574_2.patch added |
---|
comment:6 Changed 8 years ago by
Alex, please review my patch. I tried to set direction without calling destroy/buildRendering.
Note: See
TracTickets for help on using
tickets.
Make widgets under discussion to support the 'textDir' property with "ltr/rtl/auto" values