Opened 7 years ago

Closed 7 years ago

#15574 closed defect (fixed)

Slider: Support for textDir property in HorizontalRuleLabels/VerticalRuleLabels

Reported by: sashash Owned by: Douglas Hays
Priority: undecided Milestone: 1.9
Component: Dijit - Form Version: 1.7.3
Keywords: Cc:
Blocked By: Blocking:

Description

Support for base text direction in HorizontalRuleLabels/VerticalRuleLabels?

Attachments (3)

BidiRulers.patch​ (8.0 KB) - added by bill 7 years ago.
Patch from Alex Shensis (IBM, CCLA)
BidiRulers.2.patch​ (10.5 KB) - added by bill 7 years ago.
15574_2.patch​ (9.2 KB) - added by Douglas Hays 7 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 7 years ago by sashash

Make widgets under discussion to support the 'textDir' property with "ltr/rtl/auto" values

Changed 7 years ago by bill

Attachment: BidiRulers.patch​ added

Patch from Alex Shensis (IBM, CCLA)

comment:2 Changed 7 years ago by bill

Milestone: tbd → 2.0
Owner: changed from Douglas Hays to bill
Status: new → assigned

Changed 7 years ago by bill

Attachment: BidiRulers.2.patch​ added

comment:3 Changed 7 years ago by bill

Milestone: 2.0 → 1.9
Summary: Support for textDir property in HorizontalRuleLabels/VerticalRuleLabels → Slider: Support for textDir property in HorizontalRuleLabels/VerticalRuleLabels

comment:4 Changed 7 years ago by bill

Owner: changed from bill to Douglas Hays

I don't know why I assigned this to myself, seems like it should be for Doug.

comment:5 Changed 7 years ago by bill

Also, seems strange to call destroyRendering(false) rather than destroyRendering(). Theoretically the former will leave the old DOM around. Is that what we want? (Of course, maybe the whole idea to support dyanamically changing the textDir is a mistake too, if we need code this complicated to do it.)

Changed 7 years ago by Douglas Hays

Attachment: 15574_2.patch​ added

comment:6 Changed 7 years ago by Douglas Hays

Alex, please review my patch. I tried to set direction without calling destroy/buildRendering.

comment:7 Changed 7 years ago by Douglas Hays

Resolution: → fixed
Status: assigned → closed

In [29595]:

Fixes #15574. Add custom _setTextDirAttr method to HorizontalRuleLabels? to iterate over all labels to provide a contextual direction. Added automated test.

Note: See TracTickets for help on using tickets.