[patch][cla] Reg Exp for the path is incorrect causing render to not work as expected

[j105rob]

pathSvgRegExp variable defined as /([A-Za-z])|(\d+(\.\d+)?)|(\.\d+)|(-\d+(\.\d+)?)|(-\.\d+)/g

does not correctly parse the path; should a segment of a path be defined in scientific notation (e.g. -6e-9) the result of the regex does not pass the correct information into the shape object and causes the render to render the image incorrectly;

We modified the regex to: /(\d+(\.\d+)?[Ee]-\d+)|(-\d+(\.\d+)?[Ee]-\d+)|([A-Za-z])|(\d+(\.\d+)?)|(\.\d+)|(-\d+(\.\d+)?)|(-\.\d+)/g

which allowed the expected data to be passed to the renderer and rendered the image as expected.

I am not submitting a patch file because we have other changes we need to submit, but this is a bug which can be fixed in the short term.

Thanks, j105Rob.

[dylan]

Per Thomas L. Shinnick on the mailing list:

---

As described above. Still broken in 1.8.3. Here's what I was going to submit before finding this report:

Dojox/gfx::createPath fails on numbers with exponents

Working with path strings as output to SVG files by popular external program "Inkscape". These path strings often contain a full range of number value formats, including numbers with exponents.

The number format for path data in SVG is documented

​http://www.w3.org/TR/SVG11/paths.html#PathData
​http://www.w3.org/TR/SVG11/types.html#DataTypeNumber

The format is described as

      number ::= integer ([Ee] integer)?
                 | [+-]? [0-9]* "." [0-9]+ ([Ee] integer)?

To split up incoming path strings into actions and arguments

dojox/gfx/path.js::_setPath()

uses a regex published as

dojox/gfx/_base.js::pathSvgRegExp

This regex does not recognize number exponents and so the parsed path string has scattered 'E' and/or 'e' "actions" leftover. This causes paths to not be displayed, presumably because of the invalid actions.

Fix is to recognize numbers that include exponents.

--- _base.js.original   2012-07-30 20:46:04.000000000 -0500
+++ _base.js    2013-02-21 19:40:15.899727000 -0600
@@ -902,7 +902,7 @@
                //              a constant regular expression used to split a SVG/VML path into primitive components
                // tags:
                //              private
-               pathSvgRegExp: /([A-Za-z])|(\d+(\.\d+)?)|(\.\d+)|(-\d+(\.\d+)?)|(-\.\d+)/g,
+               pathSvgRegExp: /([A-DF-Za-df-z])|([-+]?\d*[.]?\d+(?:[eE][-+]?\d+)?)/g,

                equalSources: function(a, b){
                        // summary:

Note that this regex reflects the number formats in SVG specs. There is one format that is not permitted there -- "9." -- an integer followed by a decimal point *not* followed by other digits. A more permissive regex might be more bulletproof.

I have not yet looked at modifications to tests to prove the failing.
Edit: since the bug database had errors preventing my comment a couple days ago, I looked at the tests. These modifications show the problem and the fix:

C:\Toms\Study\bliss\JS\dojo1\static\dojox\gfx\tests>diff test_setPath.html.original test_setPath.html
29c29
<               .createPath("M100 100 200 100 200 200C200 250 150 250 100 200S50 100 100 100z")
---
>               .createPath("M100 100 200 100 200 200C200 250 150 250 1E2 200S50 1E2 1E2 100z")
43c43
<               .createPath("m100 100 100 0 0 100q0 50-75-25t-25-75z")
---
>               .createPath("m100 1E2 1E2 0 0 100q0 50-75-25t-25-75z")
50c50
<               .createPath("M100 100 200 100 200 200Q200 250 125 175T100 100z")
---
>               .createPath("M100 1E2 200 1E2 200 200Q200 250 125 175T100 100z")
57c57
<               .createPath("m100 100h100v100q0 50-75-25t-25-75z")
---
>               .createPath("m100 100h100v1E2q0 50-75-25t-25-75z")

---

[dylan]

Verified that both j105b and Thomas have CLAs on file.

We should fix this for 1.9.

[bill]

Bumping this ticket since we are past the deadline for the 1.9RC. The fix can be put into 1.9.1 too, if desired.

[Eugene Lazutkin]

Looks trivial enough, and follows the standard. Should be committed.

[Eric Durocher]

Fixed in master: ​https://github.com/dojo/dojox/commit/f4a8237b8301c0db7b49a316161f5bcbbfcdb39c Backported to 1.9: ​https://github.com/dojo/dojox/commit/4c56405f00667ce463d1edb815d31a4a1900673c

Thanks j105rob and Thomas L. Shinnick.