Opened 7 years ago

Closed 7 years ago

#15557 closed defect (fixed)

[cla] [patch] dojox.Grid loses scroll state if columns are re-ordered

Reported by: Karl Tiedt Owned by: Evan
Priority: undecided Milestone: 1.7.4
Component: DojoX Grid Version: 1.7.3
Keywords: Cc:
Blocked By: Blocking:

Description

One of our teams has reported this issue with a very simple fix.

Basically if you go to any grid page, scroll down in the grid, and then start to drag a column header to re-order them... even if you cancel it... the grid will re-render and lose scroll state.

Attached is a patch again 1.7.2 just to show the fix they have been using.

Evan, do you see reason why this wouldn't be a good fix to make?

Attachments (1)

15557.patch (369 bytes) - added by Karl Tiedt 7 years ago.
patch against 1.7.2 (just to illustrate the simple fix)

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by Karl Tiedt

Attachment: 15557.patch added

patch against 1.7.2 (just to illustrate the simple fix)

comment:1 Changed 7 years ago by Evan

Milestone: tbd1.7.4

It's a good fix, working nicely on all browsers. My understanding is the major diff between grid.render() and grid.update() is whether the scrollTop will be retained.

comment:2 Changed 7 years ago by Evan

Resolution: fixed
Status: newclosed

In [29050]:

Fixes #15557 !strict, change to grid.update() for retaining scrollTop after column moved, also applied to 1.7.x branch, thanks ktiedt!

Note: See TracTickets for help on using tickets.