Opened 7 years ago

Closed 7 years ago

#15532 closed defect (fixed)

[patch][ccla] dojox/gfx uses global reference to dojo in _base._getUniqueId

Reported by: ben hockey Owned by: Patrick Ruzand
Priority: high Milestone: 1.8
Component: DojoX GFX Version: 1.7.2
Keywords: Cc: cjolif, Patrick Ruzand
Blocked By: Blocking:

Description

when globals are remapped via the loader's packageMap config, global references will break. the patch below fixes a reference to the global dojo in dojox/gfx/_base.js

  • dojox/gfx/_base.js

     
    1 define(["dojo/_base/lang", "dojo/_base/html", "dojo/_base/Color", "dojo/_base/sniff", "dojo/_base/window",
     1define(["dojo/_base/kernel", "dojo/_base/lang", "dojo/_base/Color", "dojo/_base/sniff", "dojo/_base/window",
    22            "dojo/_base/array","dojo/dom", "dojo/dom-construct","dojo/dom-geometry"],
    3 function(lang, html, Color, has, win, arr, dom, domConstruct, domGeom){
     3function(kernel, lang, Color, has, win, arr, dom, domConstruct, domGeom){
    44        // module:
    55        //              dojox/gfx
    66        // summary:
     
    147147                //              returns a unique string for use with any DOM element
    148148                var id;
    149149                do{
    150                         id = dojo._scopeName + "xUnique" + (++uniqueId);
     150                        id = kernel._scopeName + "xUnique" + (++uniqueId);
    151151                }while(dom.byId(id));
    152152                return id;
    153153        };

Change History (4)

comment:1 Changed 7 years ago by ben hockey

Cc: cjolif added
Milestone: tbd1.8
Priority: undecidedhigh

the patch also removes an unused dependency on dojo/_base/html

comment:2 Changed 7 years ago by cjolif

Cc: Patrick Ruzand added

comment:3 Changed 7 years ago by Patrick Ruzand

Owner: changed from Eugene Lazutkin to Patrick Ruzand
Status: newassigned

comment:4 Changed 7 years ago by Patrick Ruzand

Resolution: fixed
Status: assignedclosed

In [28936]:

cleanup global, fixes #15532 (thx neonstalwart)

Note: See TracTickets for help on using tickets.