Opened 9 years ago
Closed 9 years ago
#15532 closed defect (fixed)
[patch][ccla] dojox/gfx uses global reference to dojo in _base._getUniqueId
Reported by: | ben hockey | Owned by: | Patrick Ruzand |
---|---|---|---|
Priority: | high | Milestone: | 1.8 |
Component: | DojoX GFX | Version: | 1.7.2 |
Keywords: | Cc: | cjolif, Patrick Ruzand | |
Blocked By: | Blocking: |
Description
when globals are remapped via the loader's packageMap config, global references will break. the patch below fixes a reference to the global dojo
in dojox/gfx/_base.js
-
dojox/gfx/_base.js
1 define(["dojo/_base/ lang", "dojo/_base/html", "dojo/_base/Color", "dojo/_base/sniff", "dojo/_base/window",1 define(["dojo/_base/kernel", "dojo/_base/lang", "dojo/_base/Color", "dojo/_base/sniff", "dojo/_base/window", 2 2 "dojo/_base/array","dojo/dom", "dojo/dom-construct","dojo/dom-geometry"], 3 function( lang, html, Color, has, win, arr, dom, domConstruct, domGeom){3 function(kernel, lang, Color, has, win, arr, dom, domConstruct, domGeom){ 4 4 // module: 5 5 // dojox/gfx 6 6 // summary: … … 147 147 // returns a unique string for use with any DOM element 148 148 var id; 149 149 do{ 150 id = dojo._scopeName + "xUnique" + (++uniqueId);150 id = kernel._scopeName + "xUnique" + (++uniqueId); 151 151 }while(dom.byId(id)); 152 152 return id; 153 153 };
Change History (4)
comment:1 Changed 9 years ago by
Cc: | cjolif added |
---|---|
Milestone: | tbd → 1.8 |
Priority: | undecided → high |
comment:2 Changed 9 years ago by
Cc: | Patrick Ruzand added |
---|
comment:3 Changed 9 years ago by
Owner: | changed from Eugene Lazutkin to Patrick Ruzand |
---|---|
Status: | new → assigned |
Note: See
TracTickets for help on using
tickets.
the patch also removes an unused dependency on dojo/_base/html