Changes between Initial Version and Version 1 of Ticket #15531, comment 3
- Timestamp:
- Aug 26, 2012, 8:22:50 AM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #15531, comment 3
initial v1 1 1 The patch can be simplified by removing the second argument to applyTextDir() (see [29559]). 2 2 3 Also likely the _setTextDirAttr() functionality in Button.js should insteadbe moved into _BidiSupport::_setTextDirAttr(), by either generalizing that existing method to apply to this.containerNode||this.focusNode(if this.displayNode is not set), or by perhaps setting up a new data-dojo-attach-point called textDirNode (or something like that).3 Also, same as #15654, likely the _setTextDirAttr() functionality in Button.js should instead be moved into _BidiSupport::_setTextDirAttr(), by either generalizing that existing method to apply to `this.containerNode||this.focusNode` (if this.displayNode is not set), or by perhaps setting up a new data-dojo-attach-point called textDirNode (or something like that).
