Button: control of Base text direction

[wajnberg]

Support for textDir property in Button, ToggleButton?, DropDownButton? and ComboButton?, same as for form widget. The core support for base text direction (via textDir) was introduced via #12367.

[bill]

I am noticing a lot of duplication across dijit, with lots of _setTextDirAttr methods that are basically the same. It seems like it would be better to have a single method in _BidiSupport.js that handled simple cases like Button and MenuItem.

[bill]

updated patch from Moshe Wajnberg

[bill]

The patch can be simplified by removing the second argument to applyTextDir() (see [29559]).

Also, same as #15654, likely the _setTextDirAttr() functionality in Button.js should instead be moved into _BidiSupport::_setTextDirAttr(), by either generalizing that existing method to apply to this.containerNode||this.focusNode (if this.displayNode is not set), or by perhaps setting up a new data-dojo-attach-point called textDirNode (or something like that).

[Douglas Hays]

I attached a patch that needs review/testing. I changed the MenuItem/textDir references from focusNode to containerNode, and created a generalized _setTextDirAttr in _BidiSupport.js

[bill]

I forget why/when that code to set align is necessary, and why it would be needed exclusively for this.displayNode (but not this.containerNode etc.).

Also, one minor thing is that (at least in theory) you shouldn't need the if(this.textDir === "auto") switch because I updated _BidiSupport:: applyTextDir() to not do anything when textDir=="", and hopefully not do anything unwanted when textDir=="ltr" or "rtl".

But other than that the patch looks good to me.

[bill]

(In #15734) Needs #15531 for StackContainer? buttons.

[Douglas Hays]

In [29586]:

Fixes #15531, #15654. Proxy commit for Alex Shensis (IBM,CCLA). Create a unified _setTextDirAttr method in _BidiSupport, removing same from MenuItem?. Create a custom _setTextDirAttr method for Button, and add automated testcases.

[bill]

I'm getting failures in the menu test after this. One problem is that you didn't update MenuBarItem.html to have a textDirNode attach point, but even after fixing that I get failures.

[Douglas Hays]

In [29594]:

Fixes #15531. Add textDirNode to other MenuItem? widgets. Change tests to use textDirNode instead of focusNode. Lots of whitespace cleanup.

[bill]

In [29598]:

Need to call this._set() so watch() notifications work, refs #15531, #15734, #15764 !strict.