Opened 7 years ago

Closed 7 years ago

#15520 closed enhancement (fixed)

[patch][cla] dojox/widget/Calendar doesn't highlight month or year

Reported by: dylan Owned by: dylan
Priority: low Milestone: 1.9
Component: DojoX Widgets Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

dojox/widget/Calendar has apparently never supported a mechanism for setting a style for the currently selected month. This should be set in _CalendarYearView.js and _CalendarMonthView.js similar to how it's set in _calendarDayView.js, but does not appear to have ever been implemented (I checked back to Dojo 1.6).

Attachments (3)

patch_15520.0.diff (2.9 KB) - added by bitpshr 7 years ago.
Style current month / year just as current day is styled on dojox/widget/Calandar
patch_15520.1.diff (3.9 KB) - added by bitpshr 7 years ago.
Add selection functionality
patch_15520.2.diff (4.2 KB) - added by bitpshr 7 years ago.
Declare variables one level higher in the query

Download all attachments as: .zip

Change History (10)

comment:1 Changed 7 years ago by dylan

Status: newassigned

Will try to fix this for 1.9.

comment:2 Changed 7 years ago by bill

Milestone: 2.01.9

So, you probably meant to set the milestone to 1.9?

comment:3 Changed 7 years ago by bitpshr

Taking a stab at this one.

Changed 7 years ago by bitpshr

Attachment: patch_15520.0.diff added

Style current month / year just as current day is styled on dojox/widget/Calandar

comment:4 Changed 7 years ago by bitpshr

First pass at a patch to style the current month / year attached. Verified using dojox/widget/tests/test_CalendarViews.html.

Changed 7 years ago by bitpshr

Attachment: patch_15520.1.diff added

Add selection functionality

comment:5 Changed 7 years ago by bitpshr

This one should be good now. Both the CalendarMonthView and CalendarYearView now support proper styling of the selected month / year respectively. Existing CSS classes were used.

Changed 7 years ago by bitpshr

Attachment: patch_15520.2.diff added

Declare variables one level higher in the query

comment:6 Changed 7 years ago by dylan

In [30861]:

refs #15520, dojox/widget/Calendar highlight month or year

comment:7 Changed 7 years ago by dylan

Resolution: fixed
Status: assignedclosed
Summary: dojox/widget/Calendar doesn't highlight month or year[patch][cla] dojox/widget/Calendar doesn't highlight month or year

Thanks for the refinements and patch @bitpshr. Committed to trunk.

Note: See TracTickets for help on using tickets.