Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15517 closed defect (fixed)

AMD support for dojox/widget/Portlet

Reported by: mikeb Owned by: dante
Priority: undecided Milestone: 1.8
Component: DojoX Widgets Version: 1.7.2
Keywords: Cc: cjolif
Blocked By: Blocking:

Description

Adds AMD support for dojox/widget/Portlet so that the PortletSettings? and PortletDialogSettings? will appear in the API.

Attachments (1)

PortletAMDandDocparser.patch (26.1 KB) - added by mikeb 7 years ago.
please commit for Michael Billau (IBM, CCLA)

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by mikeb

please commit for Michael Billau (IBM, CCLA)

comment:1 Changed 7 years ago by mikeb

Cc: cjolif added

comment:2 Changed 7 years ago by cjolif

Resolution: fixed
Status: newclosed

In [28878]:

fixes #15517. Port Portlet to AMD + fix API doc. Thanks Michael Billau (IBM, CCLA).

comment:3 Changed 7 years ago by bill

Milestone: tbd1.8
Resolution: fixed
Status: closedreopened

don't forget to update dojox/dojox.profile.js so that these converted files get tagged as amd. ie update the excludes array so that these module ids aren't going to match any more.

comment:4 Changed 7 years ago by cjolif

Resolution: fixed
Status: reopenedclosed

In [28882]:

fixes #15517. Update dojox.profile after moving a module to AMD.

comment:5 Changed 7 years ago by mikeb

Thanks Bill. It looks like there are some additional dojox/widget/ modules that were converted to AMD yet not removed from the list:

AutoRotator? - http://bugs.dojotoolkit.org/ticket/13966

FisheyeList? - http://bugs.dojotoolkit.org/ticket/15248

Pager - http://bugs.dojotoolkit.org/ticket/15301

comment:6 Changed 7 years ago by Adam Peller

In [29230]:

Refs #14227 #15517 replace deprecated attr method

Note: See TracTickets for help on using tickets.