Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15516 closed defect (fixed)

[patch][ccla] charting: SelectableLegend is leaking CheckBox widgets

Reported by: ben hockey Owned by: Eugene Lazutkin
Priority: high Milestone: 1.8
Component: Charting Version: 1.7.2
Keywords: Cc: cjolif
Blocked By: Blocking:

Description

SelectableLegend? creates a number of CheckBox? widgets that are never cleaned up. given that new ones are created for each refresh of the chart, this can easily leak 100s or 1000s of widgets in a very short time. fortunately the fix is simple - track the widgets when they are created and destroy the previous set of widgets during refresh and also as part of destroy.

Attachments (1)

SelectableLegend.diff​ (2.3 KB) - added by ben hockey 7 years ago.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by ben hockey

Attachment: SelectableLegend.diff​ added

comment:1 Changed 7 years ago by ben hockey

Milestone: tbd → 1.8
Priority: undecided → high

comment:2 Changed 7 years ago by ben hockey

Cc: cjolif added

comment:3 Changed 7 years ago by cjolif

Resolution: → fixed
Status: new → closed

In [28874]:

fixes #15516. Fixes leaking child widgets with SelectableLegend. Thanks Ben Hockey (CCLA).

comment:4 Changed 7 years ago by Mathevet julien

Does it need to disconnect also handlers ?

comment:5 Changed 7 years ago by cjolif

The handlers are not registered on the Dijit widget but on the DOM nodes so they indeed won't be explicitly released by calling widget destroy method. So yes we would need to fix that as well even if that is a slightly different issue.

Note: See TracTickets for help on using tickets.