#15516 closed defect (fixed)
[patch][ccla] charting: SelectableLegend is leaking CheckBox widgets
Reported by: | ben hockey | Owned by: | Eugene Lazutkin |
---|---|---|---|
Priority: | high | Milestone: | 1.8 |
Component: | Charting | Version: | 1.7.2 |
Keywords: | Cc: | cjolif | |
Blocked By: | Blocking: |
Description
SelectableLegend? creates a number of CheckBox? widgets that are never cleaned up. given that new ones are created for each refresh of the chart, this can easily leak 100s or 1000s of widgets in a very short time. fortunately the fix is simple - track the widgets when they are created and destroy the previous set of widgets during refresh
and also as part of destroy
.
Attachments (1)
Change History (6)
Changed 9 years ago by
Attachment: | SelectableLegend.diff added |
---|
comment:1 Changed 9 years ago by
Milestone: | tbd → 1.8 |
---|---|
Priority: | undecided → high |
comment:2 Changed 9 years ago by
Cc: | cjolif added |
---|
comment:3 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:5 Changed 9 years ago by
The handlers are not registered on the Dijit widget but on the DOM nodes so they indeed won't be explicitly released by calling widget destroy method. So yes we would need to fix that as well even if that is a slightly different issue.
Note: See
TracTickets for help on using
tickets.
In [28874]: