Naming collision with dojoConfig.packages when name is "module"

[mmaxwell]

When using the variable dojoConfig prior to including Dojo, if a package name is set as "module", it appears as though the name collides with something native to the library.

Attaching screenshot of error as well as zipped test case.

[mmaxwell]

Screenshot of error.

[mmaxwell]

Zipped test case.

[ben hockey]

the names "require", "exports" and "module" have special meaning and are reserved by the AMD loader. you'll need to use another name. while you could argue that this is technically a regression, i'd say this will be closed as wontfix but i'll leave it open for rawld to make any further comments.

[mmaxwell]

Makes sense. I've already changed the name in my code. Is this documented anywhere? Is it possible to detect an override attempt and throw?

[ben hockey]

the documentation is here http://dojotoolkit.org/reference-guide/1.7/loader/amd.html#commonjs-require-exports-and-module - admittedly if you don't know what you're looking for you might not find it but i don't know how to improve that when there's such a lot of documentation.

as for detecting an override, it could possibly be done but i'm not sure if it's worth the bytes it would take. i would tend towards not adding it but i'll leave that decision to rawld.

[Rawld Gill]

@neonstalwart is correct.

Technically, the AMD spec doesn't say that the packages require, exports, and module are reserved, but I can't imagine defining packages with those names, and, although I fixed this, I couldn't bring myself to committing the cruft. I've attached a patch below if you absolutely need it.

[Rawld Gill]

patch allows package names require, exports, and module