Opened 7 years ago

Closed 7 years ago

#15505 closed defect (fixed)

Chrome on trunk sometimes jumps to start of block when hitting shift+enter with EnterKeyHandler enabled

Reported by: DJ Mountney Owned by:
Priority: high Milestone: 1.8
Component: Editor Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

This is happening in trunk (1.8), not 1.7.2.

You can use the dijit/tests/editor/EnterKeyHandling.html page to compare between 1.7.2 and trunk.

  1. Use an empty editor with the ViewSource? plugin and EnterKeyHandling? in BR Mode.
  2. Swap to ViewSource? and set the value to <p>ab</p>
  3. Swap out of source view, and place cursor at end of ab.
  4. Hit Shift-Enter
  5. Hit Backspace to remove the newline
  6. Hit Shift-Enter

Expected Result A new <BR> is added and cursor goes down a line

Actual Result On Chrome on trunk, cursor jumps to the start of the current line and there are Two BR's still in the value.

Change History (2)

comment:1 Changed 7 years ago by Jared Jurkiewicz

In [28974]:

Issue in code changes in Range API code. It was always using the global window instead of the one passed in when creating ranges. This caused Chrome to blow up (and I would have expected other browsers to die too. refs #15505

comment:2 Changed 7 years ago by Jared Jurkiewicz

Milestone: tbd1.8
Priority: undecidedhigh
Resolution: fixed
Status: newclosed

Ran tests on several browsers. Everything is passing. This looks fixed, so marking it as such, target 1.8 The break was actually pretty severe; it broke range for all W3C browsers, which breaks several plugins.

Note: See TracTickets for help on using tickets.