NodeList-data contains logic error

[iCanDo]

Executing

query(node).data();

as getter, lang.mixin (for setter) should not be executed.

if(arguments.length == 1){ r = dataCache[pid]; }

should be

if(arguments.length == 1){ return dataCache[pid]; }

[dante]

good catch. debugging shows current unit tests calling mixin() 80% of the time when it doesn't need to. The call is mostly a no-op because it is being passed undefined most times, but useless in the getter case.

tried adding a test connecting to dojo.mixin and incrementing a counter, but I guess lang.mixin !== dojo.mixin, or there is an ordering difference or something, but couldn't get it to fire. Other tests don't regress when applying change.

[iCanDo]

My solution has an error, because it not return undefined, if no data is stored.

Better solution:

if( ! dataCache[pid] && arguments.length > 1 ) {
  dataCache[pid] = {};
}

if(arguments.length == 1){ return dataCache[pid]; }

[dante]

your solution didn't change the behavior in any way. the empty literal is always created, so an empty dataset is always that literal. never undefined. you can have undefined keys, and that will return undefined, but that's not the same situation as "empty getter".

[iCanDo]

Next try:

if( typeof key == "string" ) {
  ...
} else if( arguments.length == 2 ) {
  r = lang.mixin(dataCache[pid], key);
}

[Colin Snover]

1.8 has been tagged; moving all outstanding tickets to next major release milestone.

[bill]

Bumping this ticket since we are past the deadline for the 1.9RC. The fix can be put into 1.9.1 too, if desired.

[Kris Zyp <[email protected]…>]

In 3ad07a0497649e266ba99a9e347eb9b41bd92dd6/dojo:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?