Opened 8 years ago

Closed 5 years ago

#15495 closed enhancement (fixed)

[patch][cla] Enhancement to dojox.validate.check

Reported by: hudsonfoo Owned by: dylan
Priority: high Milestone: 1.10.1
Component: Dojox Version: 1.7.2
Keywords: Cc: cjolif
Blocked By: Blocking:

Description

New features:

  • Custom error messages
  • Accepts validation function name as a string in form profile (useful for accepting profile from JSON)

Attachments (2)

check.js.patch (4.9 KB) - added by hudsonfoo 8 years ago.
Unified diff of check.js
validate_check_demo.html (2.9 KB) - added by hudsonfoo 8 years ago.
Demo of new validate.check

Download all attachments as: .zip

Change History (13)

Changed 8 years ago by hudsonfoo

Attachment: check.js.patch added

Unified diff of check.js

Changed 8 years ago by hudsonfoo

Attachment: validate_check_demo.html added

Demo of new validate.check

comment:1 Changed 8 years ago by cjolif

Cc: cjolif added

hudsonfoo, I don't find your username here: http://dojofoundation.org/about/claCheck. Did you sign the CLA? If yes under which name? Thanks.

comment:2 Changed 7 years ago by hudsonfoo

Check with my email address im@…

Not sure why my username isn't attached to my CLA. Sorry about that.

comment:3 Changed 7 years ago by cjolif

Summary: Enhancement to dojox.validate.check[patch][cla] Enhancement to dojox.validate.check

I've checked and this is ok. Thanks.

comment:4 Changed 7 years ago by Adam Peller

Owner: changed from Adam Peller to dylan
Status: newassigned

comment:5 Changed 7 years ago by dylan

Milestone: tbd1.10
Priority: undecidedlow

I missed the deadline for 1.9, I will add this in May for 1.10.

comment:6 Changed 6 years ago by dylan

Priority: lowhigh

We should really try to review/land this one for 1.10.

comment:7 Changed 6 years ago by dylan

Added pull request at https://github.com/dojo/dojox/pull/102

This could use a review.

comment:8 Changed 6 years ago by dylan

Resolution: fixed
Status: assignedclosed

comment:10 Changed 5 years ago by dylan

Milestone: 1.10
Resolution: fixed
Status: closedreopened

This has introduced a regression, see #18223

comment:11 Changed 5 years ago by dylan

Milestone: 1.10.1
Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.