Opened 7 years ago

Closed 7 years ago

#15489 closed defect (fixed)

Scatter chart does not render on Legend correctly

Reported by: Jared Jurkiewicz Owned by: cjolif
Priority: undecided Milestone: 1.8
Component: Charting Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

The scatter plot for dojox.charting does not propagate through the marker style so that the legend can render the scatter plot symbol as the icon in the legend.

I'll be attaching a patch that should resolve this.

Attachments (1)

15489.patch (1.2 KB) - added by Jared Jurkiewicz 7 years ago.
Quick patch that should resolve it.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by Jared Jurkiewicz

Attachment: 15489.patch added

Quick patch that should resolve it.

comment:1 Changed 7 years ago by Mathevet julien

I fixed also in #15421

I didn't modify Legend. I think only Scatter need to be fixed:

if(frontMarkers.length){
-	run.dyn.stroke = frontMarkers[frontMarkers.length - 1].getStroke();
-	run.dyn.fill   = frontMarkers[frontMarkers.length - 1].getFill();
+	run.dyn.marker = theme.symbol;
+	run.dyn.markerFill = frontMarkers[frontMarkers.length - 1].getFill();
+	run.dyn.markerStroke = frontMarkers[frontMarkers.length - 1].getStroke();
 }

Last edited 7 years ago by Mathevet julien (previous) (diff)

comment:2 Changed 7 years ago by cjolif

Status: newopen

comment:3 Changed 7 years ago by cjolif

Milestone: tbd1.8
Owner: changed from Eugene Lazutkin to cjolif
Status: openassigned

comment:4 Changed 7 years ago by cjolif

In [28806]:

refs #15489. Taking inspiration from both moogle & jaredj (CLA) here but coming up with yet another version. !strict.

comment:5 Changed 7 years ago by cjolif

I've taken yet another (very similar) approach. Let me know if that does not work for you.

comment:6 Changed 7 years ago by cjolif

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.