Changes between Initial Version and Version 1 of Ticket #15486, comment 10


Ignore:
Timestamp:
Oct 3, 2012, 9:03:22 AM (7 years ago)
Author:
cjolif
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15486, comment 10

    initial v1  
    11Hi Ben, I'll look at !CartesianBase incompatibility, I agree we should do our best to keep compatibility here. I just wanted to avoid querying several times those values and so I passed them as arguments. But I can certainly get them directly in the cleanGroup method.
    22
    3 For _IndicatorElement, this was/is a private class. So I except you might have to change some code to get it back running on your side. In particular there is a noClip optional argument that is added to !CartesianBase cleanGroup. It is set to true in the new !_IndicatorElement code (because you don't want the indicator to be clipped to the plot area). If you set it to true you should not need the dims & offsets. So cleanGroup should be back working even if called at some point where you don't have the dims/offsets.
     3For _IndicatorElement, this was/is a private class. So I except you might have to change some code to get it back running on your side. In particular there is a noClip optional argument that is added to !CartesianBase cleanGroup. It is set to true in the new Indicator code (because you don't want the indicator to be clipped to the plot area) which the new !_IndicatorElement inherits from. If you set it to true you should not need the dims & offsets. So cleanGroup should be back working even if called at some point where you don't have the dims/offsets.
    44
    55