Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15473 closed defect (fixed)

[patch][cla] observeHandle used in dojox/charting/StoreSeries does not have a dismiss function

Reported by: ben hockey Owned by: Eugene Lazutkin
Priority: blocker Milestone: 1.7.3
Component: Charting Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

  • StoreSeries.js

     
    5252                        // summary:
    5353                        //              Clean up before GC.
    5454                        if(this.observeHandle){
    55                                 this.observeHandle.dismiss();
     55                                this.observeHandle.remove();
    5656                        }
    5757                },
    5858       
     
    7272                        var objects = this.objects = [];
    7373                        var self = this;
    7474                        if(this.observeHandle){
    75                                 this.observeHandle.dismiss();
     75                                this.observeHandle.remove();
    7676                        }
    7777                        var results = this.store.query(this.kwArgs.query, this.kwArgs);
    7878                        Deferred.when(results, function(objects){

Change History (6)

comment:1 Changed 7 years ago by ben hockey

Milestone: tbd1.8
Priority: undecidedblocker

comment:2 Changed 7 years ago by ben hockey

note that this patch depends on r28715. if someone was to backport this fix to the 1.7 branch, they would need to use cancel rather than remove

comment:3 Changed 7 years ago by cjolif

In [28763]:

refs #15473. Fixing removal of observe handler. Thanks neonstalwart.

comment:4 Changed 7 years ago by cjolif

In [28764]:

refs #15473. Fixing removal of observe handler. Thanks neonstalwart.

comment:5 Changed 7 years ago by cjolif

Milestone: 1.81.7.3
Resolution: fixed
Status: newclosed

comment:6 Changed 7 years ago by ben hockey

thanks.

Note: See TracTickets for help on using tickets.