Opened 7 years ago

Closed 7 years ago

#15465 closed defect (fixed)

dojox/mvc/sync API problem parameter names need to be reversed.

Reported by: Ed Chatelain Owned by: Ed Chatelain
Priority: high Milestone: 1.8
Component: DojoX MVC Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

The current API has

sync(target, targetProp, source, sourceProp, options);

But it should be

sync(source, sourceProp, target, targetProp, options);

Because the initial value is copied from the first one to the second, so currently the initial value is copied from the target to the source which is wrong.

Since sync is new in 1.8 this change will not break existing apps, but even if someone has an app written for 1.8 the change should not require an update in most cases. But if an application is using a converter (or a transform) and the code in the converter is referencing this.target or this.source those references will have to be switched.

Attachments (2)

mvc-syncApi-15465.patch (32.6 KB) - added by Ed Chatelain 7 years ago.
Patch with the change for dojox/mvc/sync and testcase updates related to the change.
mvc-bindMixinApi-15465.patch (17.7 KB) - added by Ed Chatelain 7 years ago.
Another update related to reversing the source and target parameters. Thanks to Sudoh-san. (IBM, CCLA)..

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by Ed Chatelain

Priority: undecidedhigh
Status: newassigned

Changed 7 years ago by Ed Chatelain

Attachment: mvc-syncApi-15465.patch added

Patch with the change for dojox/mvc/sync and testcase updates related to the change.

comment:2 Changed 7 years ago by cjolif

In [28736]:

refs #15465. Changes for dojox/mvc/sync arguments and testcase updates related to the change. Thanks Ed Chatelain (IBM, CCLA). !strict.

Changed 7 years ago by Ed Chatelain

Another update related to reversing the source and target parameters. Thanks to Sudoh-san. (IBM, CCLA)..

comment:3 Changed 7 years ago by cjolif

In [28786]:

refs #15465. Another update related to reversing the source and target parameters. Thanks to Sudoh-san. (IBM, CCLA). !strict.

comment:4 Changed 7 years ago by cjolif

I committed the part of the patch concerning the reversing of arguments. For what seems to be an unrelated bug fixes in equal.js and considering the beta approaching can you please submit a separate ticket (with a test case) so that we can track this bug fix separately just in case. Thanks.

comment:5 Changed 7 years ago by Ed Chatelain

Milestone: tbd1.8
Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.