Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15456 closed defect (fixed)

TitlePane: when toggleable is false, don't show arrowNode image

Reported by: Geoff Bourne Owned by: bill
Priority: undecided Milestone: 1.8
Component: Dijit Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

When a TitlePane is configured toggleable=false it seems more intuitive to not show the arrow indicator at all. As it is, the arrow appears as it would in the dijitOpen state.

Referring to the claro theme, the css

http://svn.dojotoolkit.org/src/dijit/trunk/themes/claro/TitlePane.css

could drive the "hiding" of the arrowNode when in the dijitFixedOpen state with this entry

.claro .dijitTitlePane .dijitFixedOpen .dijitArrowNode {
  background-image: none;
}

Attachments (3)

TitlePane dijit css not present.png (179.1 KB) - added by Geoff Bourne 7 years ago.
dijit.css was not pulled in with use of TitlePane?
Screen rendering and styling inspection.png (160.1 KB) - added by Geoff Bourne 7 years ago.
Rendering and styling inspection in Chrome
batts.jsp (1.5 KB) - added by Geoff Bourne 7 years ago.
JSP file itself

Download all attachments as: .zip

Change History (10)

comment:1 Changed 7 years ago by bill

Description: modified (diff)
Milestone: tbd1.8
Owner: set to bill
Status: newassigned
Summary: When dijit/TitlePanel toggleable is false, don't show arrowNode imageTitlePane: when toggleable is false, don't show arrowNode image

There's no such thing as TitlePanel so I'll assume you mean TitlePane. I already fixed this in [27076].

comment:2 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

Changed 7 years ago by Geoff Bourne

dijit.css was not pulled in with use of TitlePane?

comment:3 Changed 7 years ago by Geoff Bourne

Thanks for interpreting the widget I really meant. In the attached screenshot I am showing the HTML source of my page and that the Chrome dev tools shows dijit.css didn't get included automatically.

Do I need to manually reference that css? The reference manual infers that themes pull that css in when needed.

Changed 7 years ago by Geoff Bourne

Rendering and styling inspection in Chrome

Changed 7 years ago by Geoff Bourne

Attachment: batts.jsp added

JSP file itself

comment:4 Changed 7 years ago by bill

You are pulling in http://ajax.googleapis.com/ajax/libs/dojo/1.7.2/dijit/themes/claro/claro.css which includes dijit.css. Therefor you don't need to include it directly. Not sure why that isn't working for you.

comment:5 Changed 7 years ago by Geoff Bourne

Strange, both the google and yandex hosted copies show only inline content and are missing the addition you had made. The only thing matching .dijitFixedOpen is

.dijitFixedOpen, .dijitFixedClosed {
	
	cursor: default;
}

Maybe I have some stale copy cached. I'll investigate more with wget, IE, etc.

comment:6 Changed 7 years ago by bill

Oh right... this is fixed in 1.8, not 1.7.

comment:7 Changed 7 years ago by Geoff Bourne

Sorry for the false alarm. I got confused when I saw the source download of 1.7.2 copy of that file contains a bunch of @import's, starting with

@import url("../dijit.css");

Note: See TracTickets for help on using tickets.