Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#15450 closed defect (fixed)

"transformJobs" functions accidentally refer to global bc reference

Reported by: James Thomas Owned by: Rawld Gill
Priority: low Milestone: 1.8
Component: BuildSystem Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:


Small issue I noticed when playing with the transform jobs....

Arguments in the "transformJobs" array in buildControlDefault.js are passed in the resource to tag along with a reference to the build control instance.

A number of the current jobs don't include a second function parameter, relying on the fact that there's the same argument name as the module dependency listed above. Those functions should match the others, will use the local function parameter rather than the module reference.

Attachments (1)

buildControlDefault.patch (2.0 KB) - added by James Thomas 10 years ago.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by James Thomas

Attachment: buildControlDefault.patch added

comment:1 Changed 10 years ago by James Thomas

Component: GeneralBuildSystem
Owner: set to Rawld Gill
Priority: undecidedlow

comment:2 Changed 10 years ago by Rawld Gill

Resolution: fixed
Status: newclosed

In [29113]:

make bc a lexical variable for all transform items; fixes #15450; !strict

comment:3 Changed 10 years ago by bill

Milestone: tbd1.8
Note: See TracTickets for help on using tickets.