Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#15443 closed defect (fixed)

[patch] [cla] remove unused dependencies and avoid loading dojo/main

Reported by: bill Owned by: Rawld Gill
Priority: undecided Milestone: 1.8
Component: BuildSystem Version: 1.7.2
Keywords: Cc: Adam Peller
Blocked By: Blocking:

Description

See attached patch. It removes unused dependencies, and loads "dojo/json" rather than "dojo" itself. I'd like to just use the JSON package directly but unfortunately it doesn't work from rhino.

I'm having problems testing though, when I bring up test_Dialog.html it has the wrong path trying to load dojo modules such as array.js. But this error is occurring on a clean checkout too, so it's probably unrelated.

Attachments (1)

buildDependencies.patch (5.4 KB) - added by bill 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by bill

Attachment: buildDependencies.patch added

comment:1 Changed 8 years ago by bill

Cc: Adam Peller added

comment:2 Changed 8 years ago by Adam Peller

better still, can we use native JSON routines?

comment:3 Changed 8 years ago by bill

I'd like to just use the native JSON routines but unfortunately they don't work from rhino.

comment:4 Changed 8 years ago by Adam Peller

They'll work if/when we upgrade to Rhino 1.7R3. Right now, we share js.jar with Shrinksafe, but we could include two different versions in our build. There's a patch pending for #9773 to upgrade Shrinksafe to 1.7R3 also, but we ran into a snag with performance problems.

Version 1, edited 8 years ago by Adam Peller (previous) (next) (diff)

comment:5 Changed 7 years ago by Rawld Gill

Resolution: fixed
Status: newclosed

In [29079]:

remove unused dependencies and avoid loading dojo/main; thanks bill; fixes #15443; !strict

comment:6 Changed 7 years ago by bill

Milestone: tbd1.8
Note: See TracTickets for help on using tickets.