#15443 closed defect (fixed)
[patch] [cla] remove unused dependencies and avoid loading dojo/main
| Reported by: | bill | Owned by: | Rawld Gill |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.8 |
| Component: | BuildSystem | Version: | 1.7.2 |
| Keywords: | Cc: | Adam Peller | |
| Blocked By: | Blocking: |
Description
See attached patch. It removes unused dependencies, and loads "dojo/json" rather than "dojo" itself. I'd like to just use the JSON package directly but unfortunately it doesn't work from rhino.
I'm having problems testing though, when I bring up test_Dialog.html it has the wrong path trying to load dojo modules such as array.js. But this error is occurring on a clean checkout too, so it's probably unrelated.
Attachments (1)
Change History (7)
Changed 8 years ago by
| Attachment: | buildDependencies.patch added |
|---|
comment:1 Changed 8 years ago by
| Cc: | Adam Peller added |
|---|
comment:2 Changed 8 years ago by
comment:3 Changed 8 years ago by
I'd like to just use the native JSON routines but unfortunately they don't work from rhino.
comment:4 Changed 8 years ago by
They'll work if/when we upgrade to Rhino 1.7R3. Right now, we share js.jar with Shrinksafe, but we could include two different versions in our build. There's a patch pending for #9773 to upgrade Shrinksafe to 1.7R3 also, but we ran into a snag with performance problems. I guess the has() calls in dojo/json should handle cutting over to the native version when it's available.
comment:6 Changed 7 years ago by
| Milestone: | tbd → 1.8 |
|---|
better still, can we use native JSON routines?