Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15435 closed defect (fixed)

regression: dojox.atom undefined variable "widget"

Reported by: haysmark Owned by: bill
Priority: undecided Milestone: 1.8
Component: Dojox Version: 1.7.2
Keywords: Cc: Colin Snover
Blocked By: Blocking: #14312

Description

There was a regression in [28656]. At least one variable, "widget," was deleted without refactoring its references. To reproduce:

  1. Load the attached test case. A list of entries should appear.
  2. Click an entry. You will get an error: "widget is not defined"

Attachments (1)

test_FeedEditor_local_declarative.html (1.4 KB) - added by haysmark 7 years ago.
Test case with editor widget.

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by haysmark

Test case with editor widget.

comment:1 Changed 7 years ago by haysmark

Owner: changed from Adam Peller to bill
Status: newassigned

comment:2 Changed 7 years ago by bill

Milestone: tbd1.8

Thanks for the catch.

comment:3 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [28698]:

fix refactoring errors from [28656], fixes #15435, refs #12863 !strict.

comment:4 Changed 7 years ago by haysmark

Blocking: 14312 added

I don't suppose livedocs will automatically get this fix? It was blocking my efforts to create an example.

comment:5 Changed 7 years ago by bill

Definitely not automatic. After the change appears on github then I can update rstWiki, and then Colin needs to update the livedocs site.

But, you can avoid waiting by using a local copy of rstwiki

comment:6 Changed 7 years ago by bill

Cc: Colin Snover added

I updated dojo in the rstwiki github repository; Colin can you update the livedocs site (pulling and doing a build)?

Last edited 7 years ago by bill (previous) (diff)

comment:7 Changed 7 years ago by Colin Snover

livedocs has been updated, let me know if you need anything else.

Note: See TracTickets for help on using tickets.