Opened 7 years ago

Closed 7 years ago

#15406 closed enhancement (fixed)

JsonRest object store should support use HTTP Headers

Reported by: dancrumb Owned by: Colin Snover
Priority: high Milestone: 1.8
Component: Data Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

JsonRest? does not allow users to set HTTP Headers.

This would be a very useful feature, especially for dealing with sotres that require any level of authentication.

A pull request has been sent to the dojo repo on github.

Here is the commit to our fork: https://github.com/vodori/dojo/commit/c23ae27888805b1bf6eaa1891bf6310c78af400a

Attachments (1)

patch-15406-nows.diff (9.2 KB) - added by Colin Snover 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by dancrumb

ttrenka recommends that this be assigned to kzyp

comment:2 Changed 7 years ago by Kenneth G. Franqueiro

Component: Storage/FlashData
Owner: changed from Shane O'Sullivan to Kris Zyp
Priority: undecidedlow
Status: newassigned

comment:3 Changed 7 years ago by Kenneth G. Franqueiro

I'd note that it looks like this changeset may have missed fixing the remove method.

comment:4 Changed 7 years ago by dancrumb

That was on purpose (although the decision may have been incorrect).

I didn't want to modify the interface of this object, and remove only takes an id.

However, in retrospect, it probably makes more sense to add an options parameter to remove than to 'maintain' an interface, especially as adding an options parameter wouldn't break any pre-existing users

comment:5 Changed 7 years ago by Colin Snover

Milestone: tbd1.8

comment:6 Changed 7 years ago by Colin Snover

Priority: lowhigh

I’ve seen several people ask/complain about this. Since we’re still not at feature freeze on 1.8 it would be great to see this, since it’s low-effort & high-impact.

Changed 7 years ago by Colin Snover

Attachment: patch-15406-nows.diff added

comment:7 Changed 7 years ago by Colin Snover

Owner: changed from Kris Zyp to Colin Snover

comment:8 Changed 7 years ago by Colin Snover

Resolution: fixed
Status: assignedclosed

In [28877]:

Enhance dojo/store/JsonRest to allow headers to be provided:

  1. for all calls, not just GET calls;
  2. directly on the store that are sent automatically with all requests for that store.

Fixes #15406.

Also fixes some doc block whitespace issues, Refs #13101.

Note: See TracTickets for help on using tickets.