Opened 8 years ago
Closed 7 years ago
#15406 closed enhancement (fixed)
JsonRest object store should support use HTTP Headers
Reported by: | dancrumb | Owned by: | Colin Snover |
---|---|---|---|
Priority: | high | Milestone: | 1.8 |
Component: | Data | Version: | 1.7.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
JsonRest? does not allow users to set HTTP Headers.
This would be a very useful feature, especially for dealing with sotres that require any level of authentication.
A pull request has been sent to the dojo repo on github.
Here is the commit to our fork: https://github.com/vodori/dojo/commit/c23ae27888805b1bf6eaa1891bf6310c78af400a
Attachments (1)
Change History (9)
comment:1 Changed 8 years ago by
comment:2 Changed 8 years ago by
Component: | Storage/Flash → Data |
---|---|
Owner: | changed from Shane O'Sullivan to Kris Zyp |
Priority: | undecided → low |
Status: | new → assigned |
comment:3 Changed 8 years ago by
I'd note that it looks like this changeset may have missed fixing the remove
method.
comment:4 Changed 8 years ago by
That was on purpose (although the decision may have been incorrect).
I didn't want to modify the interface of this object, and remove only takes an id.
However, in retrospect, it probably makes more sense to add an options
parameter to remove
than to 'maintain' an interface, especially as adding an options
parameter wouldn't break any pre-existing users
comment:5 Changed 8 years ago by
Milestone: | tbd → 1.8 |
---|
comment:6 Changed 8 years ago by
Priority: | low → high |
---|
I’ve seen several people ask/complain about this. Since we’re still not at feature freeze on 1.8 it would be great to see this, since it’s low-effort & high-impact.
Changed 7 years ago by
Attachment: | patch-15406-nows.diff added |
---|
comment:7 Changed 7 years ago by
Owner: | changed from Kris Zyp to Colin Snover |
---|
ttrenka recommends that this be assigned to kzyp