Opened 8 years ago

Closed 8 years ago

#15394 closed defect (fixed)

doc parser fails to parse dojox.mobile

Reported by: ykami Owned by: Eric Durocher
Priority: undecided Milestone: 1.8
Component: DojoX Mobile Version: 1.7.2
Keywords: Cc: bill
Blocked By: Blocking:

Description

There are two errors.

  1. SpinWheelSlot.js. The doc parser seems to be confused because scrollable.js has some self-bootstrap code, in which the define function is re-defined.
  1. dh/JsonContentHandler.js. "Error: Cannot convert non-Array to array" occurs on the following line.
  req = array.map(req, function(s){ return s.replace(/\./g, "/"); });
  require(req, function(){   <-- The error occurs on this line
   d.resolve(true);
  });

Change History (7)

comment:1 Changed 8 years ago by ykami

Cc: bill added
Milestone: tbd1.8

comment:2 Changed 8 years ago by ykami

In [28628]:

Refs #15394 Added doc comments for the doc parser to scrollable.js. Thanks Bill for your advice. !strict

comment:3 Changed 8 years ago by ykami

edurocher, please handle the second one.

comment:4 Changed 8 years ago by bill

I submitted a patch for the second issue, see https://github.com/csnover/js-doc-parse/pull/5. Assuming Colin accepts the patch as-is, then you won't need any modification to JsonContentHandler.js.

comment:5 Changed 8 years ago by Eric Durocher

OK thanks ykami and bill, I will close this when the patch is accepted.

comment:6 Changed 8 years ago by ykami

In [28635]:

Refs #15394 Completely removed the pragmas from scrollable.js and moved all the stub code for the self-bootstrap capability to tests/dojostub.js as a sample code. !strict

comment:7 Changed 8 years ago by Eric Durocher

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.