Opened 7 years ago

Closed 7 years ago

#15393 closed defect (fixed)

Exit with a non-zero error code if there are optimizer errors

Reported by: tupton Owned by: Rawld Gill
Priority: high Milestone: 1.8
Component: BuildSystem Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

Right now, the build script exits with a status of 0 even if there are errors from the optimizer. This patch exits with a non-zero error code if there are optimizer errors.

Attachments (1)

build_exit_code_optimizer_errors.patch​ (666 bytes) - added by tupton 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by tupton

Attachment: build_exit_code_optimizer_errors.patch​ added

comment:1 Changed 7 years ago by tupton

I updated the attached diff to actually check for the global object instead of just assuming it's there, as it's only present in node.

comment:2 Changed 7 years ago by dante

seemingly related to #15401

comment:3 Changed 7 years ago by Rawld Gill

Milestone: tbd → 1.8
Priority: undecided → high
Status: new → assigned
Type: enhancement → defect

comment:4 Changed 7 years ago by Rawld Gill

In [29083]:

exit with nonzero exit code===1 if errors detected; refs #15393; !strict

comment:5 Changed 7 years ago by Rawld Gill

Thanks for the patch tupton!

If you take a look at build/node/process and build/rhino/process, you'll notice that I had already normalized the exit path reporting which caused me to express your idea slightly differently.

Also, while testing this, I found that the builder behaved badly (sometimes remaining silent) when an exception was thrown by the optimize runner. Keeping this ticket open to fix that.

comment:6 Changed 7 years ago by Rawld Gill

Resolution: → fixed
Status: assigned → closed

In [29084]:

added machinery to detect, recover, and report exceptions in optimizeRunner; fixes #15393; !strict

Note: See TracTickets for help on using tickets.