Opened 9 years ago
Closed 9 years ago
#15393 closed defect (fixed)
Exit with a non-zero error code if there are optimizer errors
Reported by: | tupton | Owned by: | Rawld Gill |
---|---|---|---|
Priority: | high | Milestone: | 1.8 |
Component: | BuildSystem | Version: | 1.7.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Right now, the build script exits with a status of 0 even if there are errors from the optimizer. This patch exits with a non-zero error code if there are optimizer errors.
Attachments (1)
Change History (7)
Changed 9 years ago by
Attachment: | build_exit_code_optimizer_errors.patch added |
---|
comment:1 Changed 9 years ago by
comment:3 Changed 9 years ago by
Milestone: | tbd → 1.8 |
---|---|
Priority: | undecided → high |
Status: | new → assigned |
Type: | enhancement → defect |
comment:5 Changed 9 years ago by
Thanks for the patch tupton!
If you take a look at build/node/process and build/rhino/process, you'll notice that I had already normalized the exit path reporting which caused me to express your idea slightly differently.
Also, while testing this, I found that the builder behaved badly (sometimes remaining silent) when an exception was thrown by the optimize runner. Keeping this ticket open to fix that.
Note: See
TracTickets for help on using
tickets.
I updated the attached diff to actually check for the
global
object instead of just assuming it's there, as it's only present in node.