request/iframe and io/iframe unit test failure on ioIframeGetXml

[bill]

I'm getting:

Error: test timeout in ioIframeGetXml
ERROR IN: function ioIframeGetXml(t){ var d = new doh.Deferred(); var td = iframe.get("iframeDummyMethod.php?type=xml", { preventCache: true, handleAs: "xml" }); td.then(d.getTestCallback(function(response){ t.is(4, response.data.documentElement.getElementsByTagName("child").length); })); return d; }
FAILED test: ioIframeGetXml 2453 ms

when running dojo/tests/request/iframe.html standalone or from the test suite, on IE7.

[bill]

Likewise with io/iframe.html test. Fails in 1.7 too.

[bill]

In the headers for the HHTP request for the XML URL, FF sends:

Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8

However, IE7 sends:

Accept: image/gif, image/x-xbitmap, image/jpeg, image/pjpeg, application/x-shockwave-flash, application/vnd.ms-excel, application/vnd.ms-powerpoint, application/msword, */*

Note that text/xml is missing, although since the URL is iframeDummyMethod.php, I wouldn't expect IE to realize that it's going to return XML.

Anyway, after that, the failure apparenty depends on apache settings. On my version of apache (which is just OOTB apache on the mac), the response headers say:

Content-Type: application/xml

rather than text/xml. And apparently that leads to the hang.

[bill]

Given the decline of IE7, probably this won't be fixed.

[bill]

Happens on IE8 too.

[Bryan Forbes]

In [31293]:

Fix error with .orphan() in request/iframe. refs #15383 !strict

[Bryan Forbes]

In [31294]:

Fix error with .orphan() in request/iframe (1.8 backport). refs #15383 !strict

[Bryan Forbes]

The test was timing out because the deferred never had its errback property called. I fixed that and found out that .orphan() was being called on a NodeList? and NodeList-dom was not being brought in, so I fixed that as well.

[bill]

Thanks for the fix to the test. I guess it uncovered a real problem with our code too (#17046), so good thing you looked at it.

[bill]

PS: after Kris' fix is the change to request/iframe.js still needed?

[Bryan Forbes]

Yes. Kris' fix was simply to make query stop wrapping NodeLists it didn't need to wrap anymore. This fix brings in a module that will put a method on NodeList that the code in dojo/request/iframe needs.