Opened 7 years ago

Closed 6 years ago

#15378 closed defect (fixed)

FisheyeLite should use parseFloat instead of parseInt

Reported by: ebsq Owned by: dylan
Priority: low Milestone: 1.9
Component: DojoX Widgets Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

I believe I am using version 1.5 - but the code seems to be the same in 1.7

I had been using FisheyeLite? to fade an image in and back out - taking the css opacity value from 0.3 to 1 and back down to 0.3

This used to (seem to) work - I am unsure of when it stopped working (I don't think the code changed - perhaps a browser change). Anyway, I was able to fix the problem by updating line 112 of FisheyeLite?.js

from

   v = parseInt(cs[p])

to

   v = parseFloat(cs[p])

It seems to me that decimal values are being misread as the code currently stands. This was especially noticeable to me since the opacity can be between 0 and 1, inclusive. I wanted the opacity to revert to 0.3 after the effects, it was going to 0 instead.

Sorry if I'm not adhering to protocols - not much of a bug reporter :(

Change History (2)

comment:1 Changed 6 years ago by dylan

Milestone: tbd1.9
Owner: changed from dante to dylan
Priority: undecidedlow
Status: newassigned

comment:2 Changed 6 years ago by dylan

Resolution: fixed
Status: assignedclosed

In [30740]:

fixes #15378, make opacity setting work correctly on dojox/widget/FisheyeLite by parsing as a float rather than as an int

Note: See TracTickets for help on using tickets.