Opened 8 years ago

Closed 8 years ago

#15371 closed defect (fixed)

dojox/mobile/deviceTheme using @theme uses the mobile theme over my theme.

Reported by: Ed Chatelain Owned by: ykami
Priority: undecided Milestone: 1.8
Component: DojoX Mobile Version: 1.7.2
Keywords: todoapp Cc: Eric Durocher, cjolif
Blocked By: Blocking:

Description

I think there is a bug with the dojox/mobile/deviceTheme.js where the mobile theme is taking precedence over my theme. I want to use @theme to be able to override the css in the dojo/mobile/themes, but that is not working because the mobile/themes one is still being used when a class is set in both.

You can see the problem with this github project: https://github.com/cjolif/dojo-todo-app

If you want to run the test you will need to checkout the branch into demos/todolist

Look in demo.html to see the setup for @themes.

When running the app, if you select and item in the list, it will take you to the Details page. From there you can inspect the first field on the page (TextArea?) and you will see that the dojox/mobile/themes/iphone is being used instead of the todolist/themes/iphone one.

I have a patch with a possible fix for this, by switching on of the for loops in deviceTheme to loop forward instead of backwards.

Attachments (1)

deviceTheme.patch (607 bytes) - added by Ed Chatelain 8 years ago.
Patch for deviceTheme to switch the order of the for loop.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Ed Chatelain

Attachment: deviceTheme.patch added

Patch for deviceTheme to switch the order of the for loop.

comment:1 Changed 8 years ago by Ed Chatelain

Cc: Eric Durocher cjolif added

comment:2 Changed 8 years ago by cjolif

Keywords: todoapp added
Milestone: tbd1.8

comment:3 Changed 8 years ago by ykami

Resolution: fixed
Status: newclosed

In [28584]:

Fixes #15371 Reversed the order of themeFiles so that later elements in the array take precedence over earlier ones. Thank you edchat for the patch. !strict

Note: See TracTickets for help on using tickets.