Opened 7 years ago

Closed 7 years ago

#15367 closed enhancement (fixed)

Declarative Builder Transform

Reported by: Kitson Kelly Owned by: Kitson Kelly
Priority: blocker Milestone: 1.8
Component: BuildSystem Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

The builder should be able to identify and build into layers both auto-require and declarative require dependencies in resources. For example an appropriately tagged HTML resources should be scanned for dependencies, like 

<div data-dojo-type="dijit/form/Button"></div>
<script type="dojo/require">
  "on": "dojo/on"
</script>

Should add dijit/form/Button and dojo/on to the dependency chain for either the dojo/dojo layer or another layer specifically identified.

This relates to features introduced in #14591 and #15118.

Attachments (3)

declarativeDeps.patch​ (7.3 KB) - added by Kitson Kelly 7 years ago.
Working patch…
declarativeDeps.2.patch​ (6.8 KB) - added by Kitson Kelly 7 years ago.
Second attempt at patch
declarativeDeps.3.patch​ (6.8 KB) - added by Kitson Kelly 7 years ago.
Change to layer flag

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by Kitson Kelly

Milestone: tbd → 1.8
Owner: changed from Rawld Gill to Kitson Kelly
Priority: undecided → high
Status: new → assigned

Changed 7 years ago by Kitson Kelly

Attachment: declarativeDeps.patch​ added

Working patch...

Changed 7 years ago by Kitson Kelly

Attachment: declarativeDeps.2.patch​ added

Second attempt at patch

comment:2 Changed 7 years ago by Kitson Kelly

Ok, revised patch to be easier.

If any resources are tagged as declarative, they will be scanned for declarative dependencies and they will be added to dojo/dojo, unless there is a layer that is flagged as declarativeIncludes: true and that layer will be used instead.

Changed 7 years ago by Kitson Kelly

Attachment: declarativeDeps.3.patch​ added

Change to layer flag

comment:3 Changed 7 years ago by Kitson Kelly

Priority: high → blocker

comment:4 Changed 7 years ago by Kitson Kelly

Resolution: → fixed
Status: assigned → closed

In [28868]:

Addition of declarative requirement transform, with help from neonstalwart thanks!, fixes #15367 !strict

Note: See TracTickets for help on using tickets.